Bug 285275

Summary:	Cosmetic improvements to InlineDisplay*Builder coordinate mapping
Product:	WebKit	Reporter:	fantasai <fantasai.bugs>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	285222

fantasai

Reported 2024-12-31 23:57:05 PST

Some improvements we could consider for InlineDisplayContentBuilder and InlineDisplayLineBuilder: - Adopt line-relative terminology to shorten variable and function names. - Use "logical left" and "logical right" consistent with their usage in RenderBlock etc. - Pass around writingMode objects directly; and clarify whose writingMode it is. - Reorganize InlineDisplayLineBuilder::build to organize its calculations better.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-12-31 23:57:14 PST

<rdar://problem/142227210>

fantasai

Comment 2 2025-01-01 00:54:12 PST

https://github.com/WebKit/WebKit/pull/38448

EWS

Comment 3 2025-01-02 14:32:01 PST

Committed 288380@main (ce9e73cd2b64): <https://commits.webkit.org/288380@main> Reviewed commits have been landed. Closing PR #38448 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.