Bug 285223

Summary: Pass WritingMode, not just isHorizontal, to TextDecorationPainter
Product: WebKit Reporter: fantasai <fantasai.bugs>
Component: TextAssignee: fantasai <fantasai.bugs>
Status: RESOLVED FIXED    
Severity: Normal CC: fantasai.bugs, vitor.roriz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 285221    

fantasai
Reported 2024-12-28 13:19:24 PST
In order to correctly adjust shadow offsets, TextDecorationPainter needs to know more about the writing mode than just whether it's horizontal or not, so let's give it the WritingMode object straight.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-12-28 13:19:33 PST
<rdar://problem/142129167>
fantasai
Comment 2 2024-12-30 10:01:57 PST
https://github.com/WebKit/WebKit/pull/38424
EWS
Comment 3 2025-01-02 13:36:40 PST
Committed 288376@main (fc44277cadb8): <https://commits.webkit.org/288376@main> Reviewed commits have been landed. Closing PR #38424 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.