Bug 281210
| Summary: | Ignore legacy mstyle attributes (background, color, fontsize, fontstyle, fontweight) when CoreMathML is enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | MathML | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, eri, harpsichen, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 281206 | ||
Frédéric Wang (:fredw)
I guess it will be enough to make MathMLElement::hasPresentationalHintsForAttribute return false for these attributes when CoreMathML is enabled here:
https://searchfox.org/wubkat/rev/168430191bc069c153b23fdddfc818adea1f2992/Source/WebCore/mathml/MathMLElement.cpp#112
Test: https://wpt.fyi/results/mathml/relations/css-styling/attribute-mapping-001.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Yes - I tested this yesterday and deleting them make us pass below WPT.
Radar WebKit Bug Importer
<rdar://problem/138099409>
Ahmad Saleem
I am assigning it to myself to do draft PR to get feedback.
Eri
I think this can be closed since we are already passing the test when CoreMathMLEnabled is on: https://searchfox.org/wubkat/source/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt
The relevant code that gates this behaviour is here: https://searchfox.org/wubkat/rev/168430191bc069c153b23fdddfc818adea1f2992/Source/WebCore/mathml/MathMLElement.cpp#195
Karl Dubost
Thanks Eri.