Bug 27644

Summary: Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 27634    
Attachments:
Description Flags
patch abarth: review+

Eric Seidel (no email)
Reported 2009-07-24 02:43:40 PDT
Update all CREATE_DOM_*_WRAPPER callers to pass globalObject This is another attempt at trying to make the patch for bug 27634 smaller. This takes care of the make_names.pl changes as well as all the supporting files. Basically I included all files which touched a CREATE_* macro.
Attachments
patch (76.18 KB, patch)
2009-07-24 02:52 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-07-24 02:52:49 PDT
Created attachment 33416 [details] patch
Adam Barth
Comment 2 2009-07-24 03:00:23 PDT
Comment on attachment 33416 [details] patch This is correct. So glad there's no Perl in this one. :)
Eric Seidel (no email)
Comment 3 2009-07-24 03:03:42 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt M LayoutTests/fast/dom/prototype-inheritance-2-expected.txt M WebCore/ChangeLog M WebCore/bindings/js/JSCDATASectionCustom.cpp M WebCore/bindings/js/JSCSSRuleCustom.cpp M WebCore/bindings/js/JSCSSValueCustom.cpp M WebCore/bindings/js/JSDOMBinding.h M WebCore/bindings/js/JSDocumentCustom.cpp M WebCore/bindings/js/JSElementCustom.cpp M WebCore/bindings/js/JSEventCustom.cpp M WebCore/bindings/js/JSHTMLCollectionCustom.cpp M WebCore/bindings/js/JSImageDataCustom.cpp M WebCore/bindings/js/JSNodeCustom.cpp M WebCore/bindings/js/JSSVGPathSegCustom.cpp M WebCore/bindings/js/JSStyleSheetCustom.cpp M WebCore/bindings/js/JSTextCustom.cpp M WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp M WebCore/bindings/js/JSXMLHttpRequestConstructor.cpp M WebCore/bindings/js/JSXSLTProcessorConstructor.cpp M WebCore/dom/make_names.pl Committed r46348 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46347 = 7252263a199478ac51b4fd3789e92820fdfcef7c (trunk) M WebCore/dom/make_names.pl M WebCore/ChangeLog M WebCore/bindings/js/JSTextCustom.cpp M WebCore/bindings/js/JSCSSValueCustom.cpp M WebCore/bindings/js/JSHTMLCollectionCustom.cpp M WebCore/bindings/js/JSCSSRuleCustom.cpp M WebCore/bindings/js/JSElementCustom.cpp M WebCore/bindings/js/JSSVGPathSegCustom.cpp M WebCore/bindings/js/JSEventCustom.cpp M WebCore/bindings/js/JSImageDataCustom.cpp M WebCore/bindings/js/JSXMLHttpRequestConstructor.cpp M WebCore/bindings/js/JSStyleSheetCustom.cpp M WebCore/bindings/js/JSDOMBinding.h M WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp M WebCore/bindings/js/JSCDATASectionCustom.cpp M WebCore/bindings/js/JSXSLTProcessorConstructor.cpp M WebCore/bindings/js/JSDocumentCustom.cpp M WebCore/bindings/js/JSNodeCustom.cpp M LayoutTests/ChangeLog M LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt M LayoutTests/fast/dom/prototype-inheritance-2-expected.txt r46348 = 3ce8b6121774b974e8bd3fb8d1327f7eb390959d (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46348
Note You need to log in before you can comment on or make changes to this bug.