Bug 27641

Summary: Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 27634    
Attachments:
Description Flags
patch abarth: review+

Eric Seidel (no email)
Reported 2009-07-24 00:03:48 PDT
Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead Actually I'm going to change these to Base::mark() instead for future-proofing. All the auto-gen bindings define a Base typedef which is the superclass. So sad that c++ doesn't just have a super:: call built-in. :(
Attachments
patch (6.78 KB, patch)
2009-07-24 00:08 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-07-24 00:08:27 PDT
Created attachment 33410 [details] patch
Adam Barth
Comment 2 2009-07-24 00:10:06 PDT
Comment on attachment 33410 [details] patch Yep. C++ is the suck.
Eric Seidel (no email)
Comment 3 2009-07-24 00:14:40 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/JSAbstractWorkerCustom.cpp M WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp M WebCore/bindings/js/JSMessageChannelCustom.cpp M WebCore/bindings/js/JSMessagePortCustom.cpp M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSNodeCustom.cpp M WebCore/bindings/js/JSNodeFilterCustom.cpp M WebCore/bindings/js/JSNodeIteratorCustom.cpp M WebCore/bindings/js/JSSVGElementInstanceCustom.cpp M WebCore/bindings/js/JSTreeWalkerCustom.cpp Committed r46322 M WebCore/ChangeLog M WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp M WebCore/bindings/js/JSNodeFilterCustom.cpp M WebCore/bindings/js/JSAbstractWorkerCustom.cpp M WebCore/bindings/js/JSNamedNodesCollection.cpp M WebCore/bindings/js/JSSVGElementInstanceCustom.cpp M WebCore/bindings/js/JSMessageChannelCustom.cpp M WebCore/bindings/js/JSMessagePortCustom.cpp M WebCore/bindings/js/JSNodeCustom.cpp M WebCore/bindings/js/JSNodeIteratorCustom.cpp M WebCore/bindings/js/JSTreeWalkerCustom.cpp r46322 = 9074277481c1c10c1941550c44bda829678c5499 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46322
Note You need to log in before you can comment on or make changes to this bug.