Bug 249320

Summary: [web-animations] Refactor CSSPropertyAnimation::blendProperties()
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 249293    

Antoine Quint
Reported 2022-12-14 09:40:05 PST
During a pull request review (https://github.com/WebKit/WebKit/pull/7615#discussion_r1048703175), Antti made the point that the CSSPropertyBlendingClient parameters which are always pointers ought to be reference since they're never null.
Attachments
Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2022-12-15 01:25:07 PST
Actually, we'll reuse this bug for a more general refactoring of CSSPropertyAnimation::blendProperties() to deal with not only a reference for CSSPropertyBlendingClient but also a variant parameter for the property to deal with both standard properties and custom properties.
Antoine Quint
Comment 2 2022-12-15 03:01:52 PST
Pull request: https://github.com/WebKit/WebKit/pull/7678
EWS
Comment 3 2022-12-15 03:24:02 PST
Committed 257910@main (24ceea27a0d5): <https://commits.webkit.org/257910@main> Reviewed commits have been landed. Closing PR #7678 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2022-12-15 03:25:19 PST
<rdar://problem/103396354>
Note You need to log in before you can comment on or make changes to this bug.