Bug 249107

Summary: canonicalUnitTypeForCategory should handle percent category
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, philn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 249131, 249132    
Bug Blocks: 189692    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Antti Koivisto
Reported 2022-12-11 13:08:02 PST
Fix some FIXMEs.
Attachments
Patch (8.20 KB, patch)
2022-12-11 13:17 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2022-12-11 13:43 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (8.61 KB, patch)
2022-12-11 22:18 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.79 KB, patch)
2022-12-11 23:27 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-12-11 13:08:23 PST
<rdar://problem/103231020>
Antti Koivisto
Comment 2 2022-12-11 13:17:51 PST
Created attachment 463989 [details] Patch
Antti Koivisto
Comment 3 2022-12-11 13:43:24 PST
Created attachment 463990 [details] Patch
Antti Koivisto
Comment 4 2022-12-11 22:18:25 PST
Created attachment 464000 [details] Patch
Tim Nguyen (:ntim)
Comment 5 2022-12-11 23:24:08 PST
Comment on attachment 464000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464000&action=review > Source/WebCore/css/typedom/CSSUnitValue.cpp:161 > auto canonicalUnit = [] (CSSUnitType unit) { > - // FIXME: We probably want to change the definition of canonicalUnitTypeForCategory so this lambda isn't necessary. > - auto category = unitCategory(unit); > - switch (category) { > - case CSSUnitCategory::Percent: > - return CSSUnitType::CSS_PERCENTAGE; > - case CSSUnitCategory::Flex: > - return CSSUnitType::CSS_FR; > - default: > - break; > - } > - auto result = canonicalUnitTypeForCategory(category); > + auto result = canonicalUnitTypeForUnitType(unit); > return result == CSSUnitType::CSS_UNKNOWN ? unit : result; > } (m_unit); Do we really need this lambda? Can we just call `canonicalUnitTypeForUnitType` directly ?
Antti Koivisto
Comment 6 2022-12-11 23:27:31 PST
Created attachment 464002 [details] Patch for landing
EWS
Comment 7 2022-12-12 00:31:47 PST
Committed 257716@main (f23f94eab4ca): <https://commits.webkit.org/257716@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464002 [details].
WebKit Commit Bot
Comment 8 2022-12-12 03:00:03 PST
Re-opened since this is blocked by bug 249131
Philippe Normand
Comment 9 2022-12-12 03:19:00 PST
Manually reverted, see https://bugs.webkit.org/show_bug.cgi?id=249133
Philippe Normand
Comment 10 2022-12-12 04:01:21 PST
Revert no longer needed.
Note You need to log in before you can comment on or make changes to this bug.