Bug 22961

Summary: Add WML <fieldset> element support.
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch
staikos: review+
Layout test results ap: review+

Nikolas Zimmermann
Reported 2008-12-22 07:27:46 PST
WML <fieldset> element should be supported.
Attachments
Initial patch (26.09 KB, patch)
2008-12-22 07:30 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
Layout test results (2.67 KB, patch)
2008-12-22 07:30 PST, Nikolas Zimmermann 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2008-12-22 07:30:32 PST
Created attachment 26202 [details] Initial patch
Nikolas Zimmermann
Comment 2 2008-12-22 07:30:50 PST
Created attachment 26203 [details] Layout test results
George Staikos
Comment 3 2008-12-22 07:33:49 PST
Comment on attachment 26202 [details] Initial patch Only part I wonder about is that by changing the argument to Node* on the RenderFieldset constructor, someone might accidentally drop an unexpected type in there one day. I don't think that's a reason for r- though.
Alexey Proskuryakov
Comment 4 2008-12-22 07:52:54 PST
Comment on attachment 26203 [details] Layout test results r=me
Nikolas Zimmermann
Comment 5 2008-12-22 07:53:55 PST
Alexey proposed to rename WMLDummyLegendElement to WMLInsertedLegendElement. Going to take care of this, before landing. Thanks for the quick review, guys.
Nikolas Zimmermann
Comment 6 2008-12-22 07:58:22 PST
(In reply to comment #3) > (From update of attachment 26202 [details] [review]) > Only part I wonder about is that by changing the argument to Node* on the > RenderFieldset constructor, someone might accidentally drop an unexpected type > in there one day. I don't think that's a reason for r- though. It's a bit weird that RenderFieldset actually took a HTMLForm*Element - this is contrary to the other RenderObject-derived classes, that all take Node*. There are no casts to HTMLForm*Element, so it's just safe.
Nikolas Zimmermann
Comment 7 2008-12-22 08:00:59 PST
Landed in r39436.
Note You need to log in before you can comment on or make changes to this bug.