Bug 227656

Summary: [OpenSSL] Implement HKDF and PBKDF2 support
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fujii.hironori, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206439    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2021-07-03 00:57:17 PDT
Implement HKDF and PBKDF2 support.
Attachments
Patch (57.95 KB, text/plain)
2021-07-07 16:23 PDT, Yoshiaki Jitsukawa 		no flags
Details
Patch (7.28 KB, patch)
2021-07-07 17:32 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2021-07-07 19:04 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2021-07-07 16:23:22 PDT
Created attachment 433091 [details] Patch
Yoshiaki Jitsukawa
Comment 2 2021-07-07 17:32:14 PDT
Created attachment 433097 [details] Patch
Fujii Hironori
Comment 3 2021-07-07 17:55:41 PDT
Comment on attachment 433097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433097&action=review > Source/WebCore/crypto/openssl/CryptoAlgorithmPBKDF2OpenSSL.cpp:49 > + if (PKCS5_PBKDF2_HMAC((const char*)key.key().data(), key.key().size(), parameters.saltVector().data(), parameters.saltVector().size(), parameters.iterations, algorithm, output.size(), output.data()) <= 0) Even though WebKit code style guideline doesn't mention, some reviewer dislikes C-style case. You should use C++-style cast. Unfortunately, it's reinterpret_cast in this case.
Yoshiaki Jitsukawa
Comment 4 2021-07-07 18:21:37 PDT
(In reply to Fujii Hironori from comment #3) > Comment on attachment 433097 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433097&action=review > > > Source/WebCore/crypto/openssl/CryptoAlgorithmPBKDF2OpenSSL.cpp:49 > > + if (PKCS5_PBKDF2_HMAC((const char*)key.key().data(), key.key().size(), parameters.saltVector().data(), parameters.saltVector().size(), parameters.iterations, algorithm, output.size(), output.data()) <= 0) > > Even though WebKit code style guideline doesn't mention, some reviewer > dislikes C-style case. You should use C++-style cast. Unfortunately, it's > reinterpret_cast in this case. Got it, I'll fix it. Thank you.
Yoshiaki Jitsukawa
Comment 5 2021-07-07 19:04:08 PDT
Created attachment 433109 [details] Patch
EWS
Comment 6 2021-07-08 12:27:00 PDT
Committed r279742 (239523@main): <https://commits.webkit.org/239523@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433109 [details].
Radar WebKit Bug Importer
Comment 7 2021-07-08 12:27:17 PDT
<rdar://problem/80337626>
Note You need to log in before you can comment on or make changes to this bug.