Bug 225586

Summary: LayoutTests/imported/w3c/web-platform-tests/fonts/math/operators.woff is missing
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Tools / TestsAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: amir_mark, clopez, dbarton, ews-watchlist, fred.wang, lmoura, sabouhallawa, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 225728    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Followup test expectation updates none

Cameron McCormack (:heycam)
Reported 2021-05-09 22:42:17 PDT
This font file is referenced by a few WPTs.
Attachments
Patch (21.71 KB, patch)
2021-05-09 22:46 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (25.77 KB, patch)
2021-05-10 14:59 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (40.50 KB, patch)
2021-05-10 23:53 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (40.43 KB, patch)
2021-05-11 14:56 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (592.27 KB, patch)
2021-05-16 21:33 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (21.71 KB, patch)
2021-05-16 22:26 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (37.17 KB, patch)
2021-05-17 01:17 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (50.10 KB, patch)
2021-05-17 15:16 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (21.71 KB, patch)
2021-05-18 17:48 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (38.29 KB, patch)
2021-05-19 17:42 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (69.91 KB, patch)
2021-05-20 01:16 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (70.75 KB, patch)
2021-05-20 14:44 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (72.83 KB, patch)
2021-05-21 19:14 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (72.84 KB, patch)
2021-05-23 20:42 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Followup test expectation updates (15.66 KB, patch)
2021-05-25 21:28 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-05-09 22:44:47 PDT
<rdar://77527890>
Cameron McCormack (:heycam)
Comment 2 2021-05-09 22:46:24 PDT
Created attachment 428155 [details] Patch
EWS Watchlist
Comment 3 2021-05-09 22:47:13 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Cameron McCormack (:heycam)
Comment 4 2021-05-10 14:59:19 PDT
Created attachment 428208 [details] Patch
Cameron McCormack (:heycam)
Comment 5 2021-05-10 23:53:27 PDT
Created attachment 428246 [details] Patch
Cameron McCormack (:heycam)
Comment 6 2021-05-11 14:56:48 PDT
Created attachment 428313 [details] Patch
Cameron McCormack (:heycam)
Comment 7 2021-05-12 00:09:57 PDT
Fred or Said, could you review this? Some tests now pass, and others still fail, but now with different values due to different text metrics with the operators.woff font.
Frédéric Wang (:fredw)
Comment 8 2021-05-12 00:17:03 PDT
Comment on attachment 428313 [details] Patch Thanks. LGTM. cc'ing lmoura as this will likely need rebase on GTK/WPE ports too.
Cameron McCormack (:heycam)
Comment 9 2021-05-12 18:39:31 PDT
I may revise the specific updates in this patch. I've just realized that some of the tests are flaky in WebKit, because of the way that the tests use document.fonts.ready() to wait until operators.woff to load. (Looks like WebKit doesn't wait for layout to be flushed, which is what would trigger the font load, before resolving the ready promise.) So I might tweak the tests to avoid that problem (since they're not testing font loading specifically), then update the expectations here afterwards.
Cameron McCormack (:heycam)
Comment 10 2021-05-16 21:33:29 PDT
Created attachment 428808 [details] Patch
Cameron McCormack (:heycam)
Comment 11 2021-05-16 22:26:06 PDT
Created attachment 428810 [details] Patch
Cameron McCormack (:heycam)
Comment 12 2021-05-17 01:17:32 PDT
Created attachment 428815 [details] Patch
Cameron McCormack (:heycam)
Comment 13 2021-05-17 15:16:58 PDT
Created attachment 428877 [details] Patch
Cameron McCormack (:heycam)
Comment 14 2021-05-18 17:48:14 PDT
Created attachment 429010 [details] Patch
Cameron McCormack (:heycam)
Comment 15 2021-05-19 17:42:44 PDT
Created attachment 429122 [details] Patch
Cameron McCormack (:heycam)
Comment 16 2021-05-20 01:16:06 PDT
Created attachment 429146 [details] Patch
Cameron McCormack (:heycam)
Comment 17 2021-05-20 14:44:00 PDT
Created attachment 429226 [details] Patch
Cameron McCormack (:heycam)
Comment 18 2021-05-21 19:14:46 PDT
Created attachment 429388 [details] Patch
Cameron McCormack (:heycam)
Comment 19 2021-05-23 20:42:50 PDT
Created attachment 429498 [details] Patch
EWS
Comment 20 2021-05-24 15:24:39 PDT
Committed r277970 (238092@main): <https://commits.webkit.org/238092@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429498 [details].
Truitt Savell
Comment 21 2021-05-25 15:24:34 PDT
The changes to expectations in https://trac.webkit.org/changeset/277970/webkit has broken 9 tests: imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005.html [ Failure ] imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006.html [ Failure ] imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html [ Failure ] Test Results: https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r278042%20(3014)/results.html
Amir Mark Jr
Comment 22 2021-05-25 16:35:12 PDT
*** Bug 226246 has been marked as a duplicate of this bug. ***
Cameron McCormack (:heycam)
Comment 23 2021-05-25 21:28:43 PDT
Created attachment 429728 [details] Followup test expectation updates
EWS
Comment 24 2021-05-26 00:19:33 PDT
Committed r278079 (238158@main): <https://commits.webkit.org/238158@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429728 [details].
Note You need to log in before you can comment on or make changes to this bug.