Bug 214487

Summary: Fixes to match BaseAudioContext.idl to spec
Product: WebKit Reporter: Clark Wang <clark_wang>
Component: Web AudioAssignee: Clark Wang <clark_wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Clark Wang
Reported 2020-07-17 11:23:06 PDT
Added in small fixes to bring BaseAudioContext.idl closer to spec. Edited a test file for PannerNode constructor to match spec and Chrome / Firefox.
Attachments
Patch (10.11 KB, patch)
2020-07-17 14:18 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Patch (10.11 KB, patch)
2020-07-17 14:27 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Patch (13.83 KB, patch)
2020-07-20 09:26 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Patch (13.96 KB, patch)
2020-07-20 12:11 PDT, Clark Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Clark Wang
Comment 1 2020-07-17 14:18:08 PDT
Created attachment 404592 [details] Patch
Clark Wang
Comment 2 2020-07-17 14:27:07 PDT
Created attachment 404593 [details] Patch
Chris Dumez
Comment 3 2020-07-17 14:54:43 PDT
Comment on attachment 404593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404593&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526 > - return PannerNode::create(*this, sampleRate()); So who is using this old factory / constructor now? If no one is, then why aren't you removing it in this patch? We don't want to keep dead code around, especially dead code that is not spec-compliant.
Clark Wang
Comment 4 2020-07-17 16:44:12 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 404593 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404593&action=review > > > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526 > > - return PannerNode::create(*this, sampleRate()); > > So who is using this old factory / constructor now? If no one is, then why > aren't you removing it in this patch? We don't want to keep dead code > around, especially dead code that is not spec-compliant. I think WebKitAudioPannerNode is still using PannerNodeBase, but otherwise I can remove old PannerNode constructor.
Clark Wang
Comment 5 2020-07-20 09:26:35 PDT
Created attachment 404720 [details] Patch
Clark Wang
Comment 6 2020-07-20 12:11:45 PDT
Created attachment 404740 [details] Patch
EWS
Comment 7 2020-07-20 14:52:55 PDT
Committed r264620: <https://trac.webkit.org/changeset/264620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404740 [details].
Radar WebKit Bug Importer
Comment 8 2020-07-20 14:53:16 PDT
<rdar://problem/65849546>
Note You need to log in before you can comment on or make changes to this bug.