Bug 210766

Summary: [WebGL2] Refactor texImage2D and texSubImage2D taking ImageBitmap, ImageData, Image, ArrayBufferView
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 209515    
Bug Blocks: 211220, 208875, 209510, 209513, 211338    
Attachments:
Description Flags
Work in progress
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Kenneth Russell
Reported 2020-04-20 13:45:48 PDT
The texImage2D and texSubImage2D entry points which upload DOM resources (Image, ImageData, ImageBitmap) to WebGL textures contain duplicated code. In order to upgrade these to WebGL 2.0 functionality and also support uploads to 3D textures, they must be refactored into common helpers.
Attachments
Work in progress (126.04 KB, patch)
2020-04-24 17:56 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-04-30 16:26 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-04-30 16:56 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-04-30 21:23 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-05-01 10:56 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-05-01 11:32 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (7.85 MB, patch)
2020-05-01 12:50 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-04-23 19:12:45 PDT
Have started this.
Kenneth Russell
Comment 2 2020-04-24 17:56:43 PDT
Created attachment 397532 [details] Work in progress
Kenneth Russell
Comment 3 2020-04-24 17:57:25 PDT
Checkpointing the current patch above - not for review or testing yet.
Kenneth Russell
Comment 4 2020-04-30 16:26:43 PDT
Created attachment 398117 [details] Patch
Kenneth Russell
Comment 5 2020-04-30 16:56:54 PDT
Created attachment 398124 [details] Patch
Kenneth Russell
Comment 6 2020-04-30 21:23:58 PDT
Created attachment 398158 [details] Patch
Kenneth Russell
Comment 7 2020-05-01 10:56:00 PDT
Created attachment 398202 [details] Patch
Kenneth Russell
Comment 8 2020-05-01 11:32:35 PDT
Created attachment 398211 [details] Patch
Kenneth Russell
Comment 9 2020-05-01 12:50:19 PDT
Created attachment 398220 [details] Patch
Kenneth Russell
Comment 10 2020-05-01 14:05:50 PDT
Requesting review at this point. The majority of this patch is the large rebaselines, which per the ChangeLog, get dozens of WebGL 2.0 conformance tests passing completely. The layout test flakes seen in some of the dry runs are unrelated to these code changes.
Dean Jackson
Comment 11 2020-05-01 14:38:51 PDT
Comment on attachment 398220 [details] Patch Our review tool can't handle this large a patch. Hopefully the cq does. I had a couple of minor comments that can be fixed in a follow-up. e.g. using enum class for TexFuncValidationSourceType and others. Thanks Ken, this is fantastic.
EWS
Comment 12 2020-05-01 14:52:55 PDT
Committed r261023: <https://trac.webkit.org/changeset/261023> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398220 [details].
Radar WebKit Bug Importer
Comment 13 2020-05-01 14:53:20 PDT
<rdar://problem/62748311>
Note You need to log in before you can comment on or make changes to this bug.