Bug 209516

Summary: [WebGL2] ReadPixels updates
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, justin_fan, kondapallykalyan, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 208875    
Bug Blocks: 126404, 209513, 214509    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Kenneth Russell
Reported 2020-03-24 15:44:57 PDT
readPixels, and readPixels into a pixel buffer object, must be updated / added for WebGL 2.0 support.
Attachments
Patch (71.08 KB, patch)
2020-07-16 18:43 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (71.19 KB, patch)
2020-07-16 18:59 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (92.87 KB, patch)
2020-07-17 13:29 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (167.46 KB, patch)
2020-07-17 14:17 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-07-14 15:09:12 PDT
Taking this.
Kenneth Russell
Comment 2 2020-07-16 10:59:25 PDT
This seems like it should be straightforward; one piece of additional WebGL 2.0 specific validation had to be added to ANGLE. However, I'm now seeing strange behavior where GL_PACK_SKIP_ROWS seems to be being ignored by the OpenGL driver for glReadPixels calls both into client memory, and into the pixel pack buffer. Still investigating.
Kenneth Russell
Comment 3 2020-07-16 18:43:45 PDT
Created attachment 404511 [details] Patch
Kenneth Russell
Comment 4 2020-07-16 18:44:14 PDT
Comment on attachment 404511 [details] Patch Not requesting review yet - want to test the upstreamed ANGLE patch first.
EWS Watchlist
Comment 5 2020-07-16 18:44:51 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 6 2020-07-16 18:59:21 PDT
Created attachment 404515 [details] Patch
Kenneth Russell
Comment 7 2020-07-17 13:16:28 PDT
While debugging layout test failures associated with this patch, bugs were discovered in the earlier addition of pixel unpack buffer support added in Bug 208875. Fixing those bugs in this patch as well so that more tests can fully pass.
Kenneth Russell
Comment 8 2020-07-17 13:29:56 PDT
Created attachment 404583 [details] Patch
Kenneth Russell
Comment 9 2020-07-17 13:36:55 PDT
It turns out that the bug fixes to the texture upload paths were actually needed to prevent regressions in WebGL 2.0 conformance tests that would otherwise have been introduced with the other correctness fixes in this patch.
Kenneth Russell
Comment 10 2020-07-17 13:37:50 PDT
Comment on attachment 404583 [details] Patch If this version of the patch passes tests, I think it's ready to land. Setting cq+.
Kenneth Russell
Comment 11 2020-07-17 14:00:43 PDT
Comment on attachment 404583 [details] Patch Undoing CQ - investigating layout test changes on bots.
Kenneth Russell
Comment 12 2020-07-17 14:17:37 PDT
Created attachment 404591 [details] Patch
Kenneth Russell
Comment 13 2020-07-17 14:18:57 PDT
Made a mistake rebaselining the layout tests in the last patch. Two more tests progress with this patch. CQ'ing.
EWS
Comment 14 2020-07-17 15:01:51 PDT
Committed r264536: <https://trac.webkit.org/changeset/264536> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404591 [details].
Radar WebKit Bug Importer
Comment 15 2020-07-17 15:02:24 PDT
<rdar://problem/65745897>
Note You need to log in before you can comment on or make changes to this bug.