Bug 207898

Summary: Add an os_log PrintStream
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, gyuyoung.kim, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2020-02-18 10:51:16 PST
Add an os_log PrintStream
Attachments
Patch (11.93 KB, patch)
2020-02-18 11:00 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (11.93 KB, patch)
2020-02-18 11:02 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2020-02-18 11:07 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (18.92 KB, patch)
2020-02-18 12:43 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.24 KB, patch)
2020-02-18 18:58 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-02-18 11:00:31 PST
Created attachment 391066 [details] Patch
Keith Miller
Comment 2 2020-02-18 11:02:32 PST
Created attachment 391068 [details] Patch
Mark Lam
Comment 3 2020-02-18 11:06:14 PST
Comment on attachment 391068 [details] Patch Patch missing files.
Keith Miller
Comment 4 2020-02-18 11:07:13 PST
Created attachment 391069 [details] Patch
Keith Miller
Comment 5 2020-02-18 12:43:44 PST
Created attachment 391077 [details] Patch
Mark Lam
Comment 6 2020-02-18 13:15:16 PST
Comment on attachment 391077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391077&action=review r=me with JSC options added. > Source/JavaScriptCore/jsc.cpp:2941 > +#if OS(DARWIN) > + setDataFile(OSLogPrintStream::open("com.apple.JavaScriptCore", "DataLog", OS_LOG_TYPE_INFO)); > +#else Please add a JSC option to invoke this so that we can also enable this os logging for the WebProcess, or whatever process is using JSC.
Keith Miller
Comment 7 2020-02-18 18:58:47 PST
Created attachment 391127 [details] Patch for landing
Mark Lam
Comment 8 2020-02-18 19:32:53 PST
Comment on attachment 391127 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=391127&action=review > Source/JavaScriptCore/runtime/Options.cpp:621 > + RELEASE_ASSERT(useOSLog()); Shouldn't this be Options::useOSLog()?
WebKit Commit Bot
Comment 9 2020-02-18 20:24:12 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2020-02-18 20:24:42 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2020-02-18 21:37:15 PST
The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2020-02-18 21:37:49 PST
Comment on attachment 391127 [details] Patch for landing Clearing flags on attachment: 391127 Committed r256910: <https://trac.webkit.org/changeset/256910>
WebKit Commit Bot
Comment 13 2020-02-18 21:37:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2020-02-18 21:38:19 PST
<rdar://problem/59579166>
Note You need to log in before you can comment on or make changes to this bug.