Bug 206113

Created attachment 387402 [details] Patch

Can you please deploy this change on https://ews-build.webkit-uat.org and provide a sample run.

Why is the services bubble here red, while saying "Passed build.webkit.org unit tests"?

(In reply to Alexey Proskuryakov from comment #3) > Why is the services bubble here red, while saying "Passed build.webkit.org > unit tests"? Pretty sure the machine running the services tests doesn't have some of the required buildbot packages.

Created attachment 387532 [details] Patch

Created attachment 387533 [details] Patch

> Pretty sure the machine running the services tests doesn't have some of the required buildbot packages. Shouldn't that be causing an error message?

(In reply to Alexey Proskuryakov from comment #7) > > Pretty sure the machine running the services tests doesn't have some of the required buildbot packages. > > Shouldn't that be causing an error message? It was, sort of. That's what many of the unit test failures for services were. Not all of them, though, some where unit tests I had failed to change.

(In reply to Alexey Proskuryakov from comment #3) > Why is the services bubble here red, while saying "Passed build.webkit.org unit tests"? Tracked in https://bugs.webkit.org/show_bug.cgi?id=206180

Created attachment 387571 [details] Patch

Comment on attachment 387571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387571&action=review Seems like python3 webkitpy tests are failing, e.g.: https://ews-build.webkit-uat.org/#/builders/8/builds/35/steps/6/logs/stdio > Tools/BuildSlaveSupport/ews-build/steps.py:696 > +class WebKitPyTest(shell.ShellCommand): Please update the 'Passed webkitpy tests' message to 'Passed python2 webkitpy tests' and 'Passed python3 webkitpy tests'. e.g.: https://ews-build.webkit-uat.org/#/builders/8/builds/37 You can use a class variable (e.g.: python_version) set in both the classes, and used in the 'message' string appropriately. > Tools/BuildSlaveSupport/ews-build/steps.py:727 > message = 'Found {} WebKitPy test failure{}: {}'.format(len(failures), pluralSuffix, failures_string) Please remove both self.build.buildFinished() lines from this getResultSummary() method. This causes the build to be finished early and prevents the RunWebKitPyPython3Tests step from running.

Created attachment 387707 [details] Patch

Comment on attachment 387707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387707&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:741 > + descriptionDone = ['webkitpy-tests'] Can move descriptionDone to base class. > Tools/BuildSlaveSupport/ews-build/steps.py:742 > + description = ['webkitpy-tests running ({})'.format(language)] Can you check if you can move description, name, jsonFileName, logfiles to base class (WebKitPyTest).

Comment on attachment 387707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387707&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:742 >> + description = ['webkitpy-tests running ({})'.format(language)] > > Can you check if you can move description, name, jsonFileName, logfiles to base class (WebKitPyTest). We won't be able to. They need language to be defined. Unless we make them properties, no, we can't move them.

Created attachment 387718 [details] Patch

Test runs: Success: https://ews-build.webkit-uat.org/#/builders/8/builds/55 Failure: https://ews-build.webkit-uat.org/#/builders/8/builds/56

Comment on attachment 387718 [details] Patch Clearing flags on attachment: 387718 Committed r254547: <https://trac.webkit.org/changeset/254547>

All reviewed patches have been landed. Closing bug.

<rdar://problem/58589889>

(In reply to Aakash Jain from comment #9) > (In reply to Alexey Proskuryakov from comment #3) > > Why is the services bubble here red, while saying "Passed build.webkit.org unit tests"? > Tracked in https://bugs.webkit.org/show_bug.cgi?id=206180 Fixed, that red bubble's tooltip now says: "Failed EWS unit tests"