Bug 205375

Summary: [WebAuthn] Merge some of the CTAP response decoder's code
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2019-12-17 21:18:46 PST
Consider merging some of the CTAP request/response encoder/decoder's code.
Attachments
Patch (9.78 KB, patch)
2020-02-07 15:17 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-02-07 15:17:41 PST
Created attachment 390134 [details] Patch
Jiewen Tan
Comment 2 2020-02-10 11:03:30 PST
Comment on attachment 390134 [details] Patch Thanks for r+ this patch, Darin.
WebKit Commit Bot
Comment 3 2020-02-10 12:07:20 PST
The commit-queue encountered the following flaky tests while processing attachment 390134 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2020-02-10 12:07:34 PST
The commit-queue encountered the following flaky tests while processing attachment 390134 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-10 12:26:09 PST
Comment on attachment 390134 [details] Patch Clearing flags on attachment: 390134 Committed r256201: <https://trac.webkit.org/changeset/256201>
WebKit Commit Bot
Comment 6 2020-02-10 12:26:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-10 12:27:18 PST
<rdar://problem/59321089>
Note You need to log in before you can comment on or make changes to this bug.