Bug 204322

Summary: Check if ITP is on before applying third-party cookie blocking
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204109
Attachments:
Description Flags
Patch
none
Patch none

John Wilander
Reported 2019-11-18 15:02:32 PST
<rdar://problem/57120772>
Attachments
Patch (18.41 KB, patch)
2019-11-18 15:05 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2019-11-18 19:47 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2019-11-18 15:05:19 PST
Created attachment 383795 [details] Patch
John Wilander
Comment 2 2019-11-18 15:05:38 PST
Comment on attachment 383795 [details] Patch Checking EWS before landing.
John Wilander
Comment 3 2019-11-18 16:06:18 PST
Looking into test failure.
John Wilander
Comment 4 2019-11-18 19:39:24 PST
Found the issue. Trunk uses a different WebsiteDataStore for the TestRunner and I must turn ITP on/off on that store. New patch coming up.
John Wilander
Comment 5 2019-11-18 19:47:06 PST
Created attachment 383834 [details] Patch
John Wilander
Comment 6 2019-11-18 19:49:16 PST
Comment on attachment 383834 [details] Patch Again checking EWS before landing. The only change is for TestController::setStatisticsEnabled() to use TestController::websiteDataStore() in the call to WKWebsiteDataStoreSetResourceLoadStatisticsEnabled().
WebKit Commit Bot
Comment 7 2019-11-18 22:30:54 PST
Comment on attachment 383834 [details] Patch Clearing flags on attachment: 383834 Committed r252623: <https://trac.webkit.org/changeset/252623>
WebKit Commit Bot
Comment 8 2019-11-18 22:30:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.