Bug 202341

Summary: Web Inspector: Sources: enable tab by default
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 203719, 205826    
Attachments:
Description Flags
Patch
joepeck: review+
Patch none

Devin Rousso
Reported 2019-09-27 22:55:16 PDT
The Sources Tab has progressed enough that it can be enabled by default. It also has enough new features that are only available in that UI that we want to be discoverable and usable without having to change any settings.
Attachments
Patch (146.67 KB, patch)
2019-09-28 21:19 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
Patch (146.27 KB, patch)
2019-10-10 14:00 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-09-28 21:19:42 PDT
Created attachment 379800 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-10-01 13:41:55 PDT
<rdar://problem/55888222>
Devin Rousso
Comment 3 2019-10-07 16:40:01 PDT Comment hidden (obsolete)
Devin Rousso
Comment 4 2019-10-07 16:41:12 PDT
*** Bug 200761 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 5 2019-10-10 13:54:54 PDT
Comment on attachment 379800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379800&action=review r=me! > Source/WebInspectorUI/UserInterface/Base/Main.js:145 > + WI.SourcesTabContentView, This should have a `.Type` suffix. > Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js:105 > Style: Lets remove this extra newline while we are here.
Devin Rousso
Comment 6 2019-10-10 13:57:27 PDT
Comment on attachment 379800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379800&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:145 >> + WI.SourcesTabContentView, > > This should have a `.Type` suffix. Ah, oops!
Devin Rousso
Comment 7 2019-10-10 14:00:43 PDT
Created attachment 380678 [details] Patch
WebKit Commit Bot
Comment 8 2019-10-10 14:57:44 PDT
Comment on attachment 380678 [details] Patch Clearing flags on attachment: 380678 Committed r250991: <https://trac.webkit.org/changeset/250991>
WebKit Commit Bot
Comment 9 2019-10-10 14:57:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.