Bug 201748

Summary: [GTK] Remove GraphicsContext3D dependency from the outside of WebGL
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, bugs-noreply, calvaris, cgarcia, commit-queue, eric.carlson, ews-feeder, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199060    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

ChangSeok Oh
Reported 2019-09-12 19:32:21 PDT
SSIA.
Attachments
Patch (7.07 KB, patch)
2019-09-12 20:35 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (7.36 KB, patch)
2019-09-13 19:06 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (7.10 KB, patch)
2019-09-13 19:48 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (7.08 KB, patch)
2019-09-13 21:17 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2019-09-12 20:35:42 PDT
Created attachment 378707 [details] Patch
ChangSeok Oh
Comment 2 2019-09-13 19:06:12 PDT
Created attachment 378770 [details] Patch
ChangSeok Oh
Comment 3 2019-09-13 19:48:10 PDT
Created attachment 378774 [details] Patch
ChangSeok Oh
Comment 4 2019-09-13 21:17:32 PDT
Created attachment 378783 [details] Patch
EWS
Comment 5 2019-09-16 09:34:01 PDT
Comment on attachment 378783 [details] Patch Rejecting attachment 378783 [details] from commit-queue. changseok@webkit.org does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
ChangSeok Oh
Comment 6 2019-09-16 09:46:51 PDT
(In reply to ews-feeder from comment #5) > Comment on attachment 378783 [details] > Patch > > Rejecting attachment 378783 [details] from commit-queue. > > changseok@webkit.org does not have committer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > > - If you do not have committer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. > > - If you have committer rights please correct the error in > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > the file (no review needed). The commit-queue restarts itself every 2 > hours. After restart the commit-queue will correctly respect your committer > rights. I forgot to lose my committership. Could anyone set cq+ instead?
Adrian Perez
Comment 7 2019-09-16 10:51:45 PDT
(In reply to ChangSeok Oh from comment #6) > (In reply to ews-feeder from comment #5) > > Comment on attachment 378783 [details] > > Patch > > > > [...] > > I forgot to lose my committership. Could anyone set cq+ instead? Done! Feel free to CC or ping me if you need cq+ for some other patches.
WebKit Commit Bot
Comment 8 2019-09-16 11:59:25 PDT
Comment on attachment 378783 [details] Patch Clearing flags on attachment: 378783 Committed r249909: <https://trac.webkit.org/changeset/249909>
WebKit Commit Bot
Comment 9 2019-09-16 11:59:27 PDT
All reviewed patches have been landed. Closing bug.
ChangSeok Oh
Comment 10 2019-09-16 12:07:37 PDT
(In reply to Adrian Perez from comment #7) > (In reply to ChangSeok Oh from comment #6) > > (In reply to ews-feeder from comment #5) > > > Comment on attachment 378783 [details] > > > Patch > > > > > > [...] > > > > I forgot to lose my committership. Could anyone set cq+ instead? > > Done! Feel free to CC or ping me if you need cq+ for some other patches. O.K. Thanks!
Note You need to log in before you can comment on or make changes to this bug.