Bug 201101

Summary: Removing fullscreen element in rAF() callback after requestFullscreen() can leave fullscreen in inconsistent state.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201188
Attachments:
Description Flags
Patch
none
Patch none

Jer Noble
Reported 2019-08-23 16:23:05 PDT
Removing fullscreen element in rAF() callback after requestFullscreen() can leave fullscreen in inconsistent state.
Attachments
Patch (22.14 KB, patch)
2019-08-26 10:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (21.24 KB, patch)
2019-08-26 10:05 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-08-23 16:42:17 PDT
<rdar://problem/54164587>
Jer Noble
Comment 2 2019-08-26 10:02:18 PDT
Created attachment 377249 [details] Patch
Jer Noble
Comment 3 2019-08-26 10:05:01 PDT
Created attachment 377251 [details] Patch
Eric Carlson
Comment 4 2019-08-26 17:29:25 PDT
Comment on attachment 377251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377251&action=review > Source/WebCore/dom/FullscreenManager.cpp:245 > + if (m_pendingFullscreenElement) Nit: this test is unnecessary > Source/WebCore/dom/FullscreenManager.cpp:271 > + if (m_pendingFullscreenElement) Ditto > LayoutTests/fullscreen/full-screen-request-removed-with-raf.html:9 > + if (document.webkitCurrentFullScreenElement && document.webkitCurrentFullScreenElement.ownerDocument) Shouldn’t this be “! document.webkitCurrentFullScreenElement.ownerDocument”?
Jer Noble
Comment 5 2019-08-27 08:02:23 PDT
Comment on attachment 377251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377251&action=review >> LayoutTests/fullscreen/full-screen-request-removed-with-raf.html:9 >> + if (document.webkitCurrentFullScreenElement && document.webkitCurrentFullScreenElement.ownerDocument) > > Shouldn’t this be “! document.webkitCurrentFullScreenElement.ownerDocument”? Yep.
Jer Noble
Comment 6 2019-08-27 09:49:46 PDT
Committed r249147: <https://trac.webkit.org/changeset/249147>
Note You need to log in before you can comment on or make changes to this bug.