Bug 200477

Summary: Public iOS SDK build is broken after r248071 (_CTFontCreateForCharactersWithLanguageAndOption)
Product: WebKit Reporter: Ali Juma <ajuma>
Component: New BugsAssignee: Ali Juma <ajuma>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fred.wang, jbedard, mmaxfield, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200241
Bug Depends on:    
Bug Blocks: 202263    
Attachments:
Description Flags
Patch youennf: review+

Ali Juma
Reported 2019-08-06 13:38:17 PDT
Public iOS SDK build is broken after r248071
Attachments
Patch (1.50 KB, patch)
2019-08-06 13:40 PDT, Ali Juma 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2019-08-06 13:40:49 PDT
Created attachment 375648 [details] Patch
Alexey Proskuryakov
Comment 2 2019-08-06 16:48:37 PDT
How will we remember to remove this workaround later? This change is pretty risky in that we may end up having different behavior indefinitely.
Alexey Proskuryakov
Comment 3 2019-08-06 16:50:12 PDT
Also, if iOS build is broken, presumably macOS build is broken too?
Jonathan Bedard
Comment 4 2019-08-06 16:53:17 PDT
(In reply to Alexey Proskuryakov from comment #3) > Also, if iOS build is broken, presumably macOS build is broken too? I believe the Catalina seed is broken too.
Ali Juma
Comment 5 2019-08-07 06:17:32 PDT
(In reply to Alexey Proskuryakov from comment #2) > How will we remember to remove this workaround later? This change is pretty > risky in that we may end up having different behavior indefinitely. I'm happy to just apply this locally for now and wait to see if the problem resolves itself with a new beta.
Alexey Proskuryakov
Comment 6 2019-08-07 13:08:49 PDT
Applying the patch locally for now seems best if that works for you.
Frédéric Wang (:fredw)
Comment 7 2019-09-26 05:35:58 PDT
@Ali: Do you still have this issue with the latest XCode release?
Frédéric Wang (:fredw)
Comment 8 2019-09-26 05:36:50 PDT
(In reply to Frédéric Wang (:fredw) from comment #7) > @Ali: Do you still have this issue with the latest XCode release? (I'm able to build WebKit with the workaround from 202264)
Ali Juma
Comment 9 2019-09-26 06:43:37 PDT
I'm able to build now. I haven't run into the problems from bug 202264 either.
Note You need to log in before you can comment on or make changes to this bug.