Bug 194994

Summary:

Update double-conversion to the latest version

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Web Template Framework

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

178319

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews117 for mac-highsierra	none
Archive of layout-test-results from ews201 for win-future	none
Patch	none
Patch	none
Patch	none
Diff showing just the changes made on top of the upstream version	none
Patch	none
Diff showing just the changes made on top of the upstream version	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none

Sam Weinig

Reported 2019-02-24 12:55:18 PST

The latest double-conversion library has some features that would be useful, such as support for single precision floats. Let's update to it.

Attachments
Patch (453.86 KB, patch) 2019-02-24 12:58 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (486.79 KB, application/zip) 2019-02-24 13:51 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (451.41 KB, application/zip) 2019-02-24 13:57 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-highsierra (549.30 KB, application/zip) 2019-02-24 14:07 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews201 for win-future (10.62 MB, application/zip) 2019-02-24 14:55 PST, EWS Watchlist	no flags	Details
Patch (429.49 KB, patch) 2019-02-24 15:02 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (429.84 KB, patch) 2019-02-24 15:34 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (431.25 KB, patch) 2019-02-24 17:20 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Diff showing just the changes made on top of the upstream version (74.05 KB, patch) 2019-02-24 17:21 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (431.32 KB, patch) 2019-02-24 20:01 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Diff showing just the changes made on top of the upstream version (73.79 KB, patch) 2019-02-24 20:02 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (431.32 KB, patch) 2019-02-24 20:14 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.41 MB, application/zip) 2019-02-24 22:32 PST, EWS Watchlist	no flags	Details
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2019-02-24 12:58:26 PST Comment hidden (obsolete)

Created attachment 362860 [details] Patch

Sam Weinig

Comment 2 2019-02-24 13:01:04 PST

This initial patch updates the library and applies most of the changes we have made to it over the years. One change it is still missing is the change to streamline strtod from https://bugs.webkit.org/show_bug.cgi?id=82857. It will have to be a bit different, due to added single precision float support, but not that different. I will finish that off before posting a final patch for review.

EWS Watchlist

Comment 3 2019-02-24 13:51:29 PST Comment hidden (obsolete)

Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11270244 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-02-24 13:51:30 PST Comment hidden (obsolete)

Created attachment 362861 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-02-24 13:57:50 PST Comment hidden (obsolete)

Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11270249 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 6 2019-02-24 13:57:51 PST Comment hidden (obsolete)

Created attachment 362862 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-02-24 14:07:37 PST Comment hidden (obsolete)

Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11270243 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2019-02-24 14:07:39 PST Comment hidden (obsolete)

Created attachment 362863 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-02-24 14:55:13 PST Comment hidden (obsolete)

Comment on attachment 362860 [details] Patch Attachment 362860 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11270398 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 10 2019-02-24 14:55:24 PST Comment hidden (obsolete)

Created attachment 362864 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Sam Weinig

Comment 11 2019-02-24 15:02:27 PST Comment hidden (obsolete)

Created attachment 362865 [details] Patch

Sam Weinig

Comment 12 2019-02-24 15:34:43 PST Comment hidden (obsolete)

Created attachment 362866 [details] Patch

Sam Weinig

Comment 13 2019-02-24 17:20:27 PST Comment hidden (obsolete)

Created attachment 362870 [details] Patch

Sam Weinig

Comment 14 2019-02-24 17:21:34 PST Comment hidden (obsolete)

Created attachment 362871 [details] Diff showing just the changes made on top of the upstream version

Sam Weinig

Comment 15 2019-02-24 20:01:37 PST Comment hidden (obsolete)

Created attachment 362877 [details] Patch

Sam Weinig

Comment 16 2019-02-24 20:02:22 PST

Created attachment 362878 [details] Diff showing just the changes made on top of the upstream version

Sam Weinig

Comment 17 2019-02-24 20:14:26 PST

Created attachment 362879 [details] Patch

EWS Watchlist

Comment 18 2019-02-24 22:32:15 PST

Comment on attachment 362879 [details] Patch Attachment 362879 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11273571 New failing tests: fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

EWS Watchlist

Comment 19 2019-02-24 22:32:17 PST

Created attachment 362885 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Darin Adler

Comment 20 2019-02-25 09:41:57 PST

(In reply to Build Bot from comment #18) > fast/viewport/ios/device-width-viewport-after-changing-view-scale.html This flaky test is causing spurious failures for me too when I am working on unrelated patches.

WebKit Commit Bot

Comment 21 2019-02-25 10:59:08 PST

Comment on attachment 362879 [details] Patch Clearing flags on attachment: 362879 Committed r242048: <https://trac.webkit.org/changeset/242048>

WebKit Commit Bot

Comment 22 2019-02-25 10:59:10 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 23 2019-02-25 11:01:23 PST

<rdar://problem/48369334>

Note You need to log in before you can comment on or make changes to this bug.