Bug 191766

Summary: Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: REOPENED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P4 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191483
Attachments:
Description Flags
Patch
none
Patch for landing none

Matt Baker
Reported 2018-11-16 12:51:51 PST
Summary: TreeOutline shouldn't select first child of an expanded element on right arrow key. Steps to Reproduce: 1. Select a tree element with at least one child 2. Expand the tree element 3. Press Right Arrow key => Selection moves to first child. In Finder and Xcode, the selection does not change. We should continue to do the following behaviors, which match the system: - Pressing the Left Arrow key when the first child of an expanded item is selected moves the selection up to the parent - Pressing the Right Arrow key when an item is collapsed expands the item
Attachments
Patch (1.91 KB, patch)
2018-11-16 12:53 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.88 KB, patch)
2018-11-16 14:03 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2018-11-16 12:53:18 PST
Created attachment 355104 [details] Patch
Devin Rousso
Comment 2 2018-11-16 13:34:42 PST
Comment on attachment 355104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355104&action=review rs=me Should we do anything special if the folder is already expanded? It seems like in that case we’d effectively be doing nothing. I suppose I’d that’s what the system does then it’s better to match 🤔 > Source/WebInspectorUI/ChangeLog:10 > + Match system behavior. This comment isn’t descriptive. Either remove it or make it more explanatory.
Matt Baker
Comment 3 2018-11-16 14:03:55 PST
Created attachment 355117 [details] Patch for landing
Matt Baker
Comment 4 2018-11-16 14:07:47 PST
(In reply to Devin Rousso from comment #2) > Comment on attachment 355104 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=355104&action=review > > rs=me > > Should we do anything special if the folder is already expanded? It seems > like in that case we’d effectively be doing nothing. I suppose I’d that’s > what the system does then it’s better to match 🤔 Doing nothing on Right Arrow when the selected item is expanded is precisely the system behavior being followed. It's curious that the opposite - selecting the parent on Left Arrow when the first child is selected - is the system behavior. 🤔
WebKit Commit Bot
Comment 5 2018-11-16 14:45:22 PST
Comment on attachment 355117 [details] Patch for landing Clearing flags on attachment: 355117 Committed r238305: <https://trac.webkit.org/changeset/238305>
WebKit Commit Bot
Comment 6 2018-11-16 14:45:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-16 14:45:54 PST
<rdar://problem/46140393>
Radar WebKit Bug Importer
Comment 8 2018-11-16 14:46:00 PST
<rdar://problem/46140392>
Devin Rousso
Comment 9 2018-11-28 15:04:18 PST
This was undone by r238599 <https://webkit.org/b/191483>.
Note You need to log in before you can comment on or make changes to this bug.