Bug 191567

Summary: Web Inspector: Styles: SpreadsheetCSSStyleDeclarationEditor.prototype.editing getter is inaccurate
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED WONTFIX    
Severity: Normal CC: inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 192282    
Bug Blocks:    
Attachments:
Description Flags
WIP
nvasilyev: review-, nvasilyev: commit-queue-
WIP
nvasilyev: review-, nvasilyev: commit-queue-
[Animated GIF] With patch applied none

Nikita Vasilyev
Reported 2018-11-12 15:15:54 PST
With Selection of Multiple Properties setting enabled, this code is no longer accurate: get editing() { return this._focused || this._inlineSwatchActive; } When a property is selected, this getter inaccurately returns true.
Attachments
WIP (7.07 KB, patch)
2018-11-15 12:26 PST, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
WIP (5.61 KB, patch)
2018-12-05 15:18 PST, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (97.98 KB, image/gif)
2018-12-05 15:22 PST, Nikita Vasilyev 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-12 15:16:20 PST
<rdar://problem/46005705>
Nikita Vasilyev
Comment 2 2018-11-15 12:26:40 PST
Created attachment 354969 [details] WIP This is NOT ready for review. I'm tabling this for now.
Nikita Vasilyev
Comment 3 2018-12-05 15:18:28 PST
Created attachment 356667 [details] WIP
Nikita Vasilyev
Comment 4 2018-12-05 15:22:05 PST
Created attachment 356668 [details] [Animated GIF] With patch applied This WIP introduces a bizarre regression. I didn't realize this refactoring would be so tricky.
Nikita Vasilyev
Comment 5 2019-06-26 18:48:57 PDT
This is a low-benefit / high-risk task. I'm not planning working on this.
Note You need to log in before you can comment on or make changes to this bug.