Bug 189495

Summary:

Modify more tests to use document.scrollingElement to access viewport scroll properties

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

Media

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rniwa, simon.fraser, tonikitoo, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/12944

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Patch	none
Patch	none

Frédéric Wang (:fredw)

Reported 2018-09-10 23:08:41 PDT

Per discussions in bug 182230, more tests should be modified to use document.scrollingElement or otherwise they are flaky. I'll also do the modification of tests in quirks mode that I left unchanged in bug 182241. Some tests (mostly in LayoutTests/fast/dom/Element) use document.body on purpose, so I won't change them either.

Attachments
Patch (114.16 KB, patch) 2018-09-10 23:19 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.32 MB, application/zip) 2018-09-11 00:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.08 MB, application/zip) 2018-09-11 00:38 PDT, EWS Watchlist	no flags	Details
Patch (113.56 KB, patch) 2018-09-11 00:44 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (112.85 KB, patch) 2018-09-11 01:28 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2018-09-10 23:19:45 PDT

Created attachment 349383 [details] Patch

EWS Watchlist

Comment 2 2018-09-11 00:26:06 PDT

Comment on attachment 349383 [details] Patch Attachment 349383 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9169925 New failing tests: fast/scrolling/rtl-point-in-iframe.html fast/multicol/body-stuck-with-dirty-bit-with-columns.html

EWS Watchlist

Comment 3 2018-09-11 00:26:08 PDT

Created attachment 349385 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-09-11 00:38:43 PDT

Comment on attachment 349383 [details] Patch Attachment 349383 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9169935 New failing tests: fast/scrolling/rtl-point-in-iframe.html fast/multicol/body-stuck-with-dirty-bit-with-columns.html

EWS Watchlist

Comment 5 2018-09-11 00:38:45 PDT

Created attachment 349386 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Frédéric Wang (:fredw)

Comment 6 2018-09-11 00:44:12 PDT

Created attachment 349387 [details] Patch

Frédéric Wang (:fredw)

Comment 7 2018-09-11 01:28:58 PDT

Created attachment 349388 [details] Patch

Antonio Gomes

Comment 8 2018-09-11 05:18:03 PDT

Comment on attachment 349388 [details] Patch r=me Ideally, we should prevent new code to use document.body on tests. is there a way?

Frédéric Wang (:fredw)

Comment 9 2018-09-11 05:23:31 PDT

(In reply to Antonio Gomes from comment #8) > Comment on attachment 349388 [details] > Patch > > r=me > > Ideally, we should prevent new code to use document.body on tests. is there > a way? Hopefully, now that the standard behavior is enabled for tests people will notice that document.body does not work.

WebKit Commit Bot

Comment 10 2018-09-11 05:48:02 PDT

Comment on attachment 349388 [details] Patch Clearing flags on attachment: 349388 Committed r235893: <https://trac.webkit.org/changeset/235893>

WebKit Commit Bot

Comment 11 2018-09-11 05:48:04 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2018-09-11 05:49:27 PDT

<rdar://problem/44340301>

Note You need to log in before you can comment on or make changes to this bug.