Bug 184985

Summary: [CMake] Require GCC 6
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, andersca, commit-queue, darin, ews-watchlist, jfbastien, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 185135    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Michael Catanzaro
Reported 2018-04-25 11:31:51 PDT
As agreed at https://lists.webkit.org/pipermail/webkit-dev/2018-March/029928.html, it's time to require GCC 6.
Attachments
Patch (5.18 KB, patch)
2018-04-25 11:45 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.59 MB, application/zip)
2018-04-25 17:25 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-25 11:43:12 PDT
(This is going to break the GTK stable bots)
Michael Catanzaro
Comment 2 2018-04-25 11:45:29 PDT
Created attachment 338764 [details] Patch
JF Bastien
Comment 3 2018-04-25 13:33:49 PDT
Naively this seems good to me, but maybe there's something I'm missing on how exactly we want to do about doing this.
Alex Christensen
Comment 4 2018-04-25 13:35:11 PDT
Comment on attachment 338764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338764&action=review > Source/WTF/wtf/Compiler.h:-97 > -#if !GCC_VERSION_AT_LEAST(5, 0, 0) > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile." > -#endif Couldn't you just increment this?
JF Bastien
Comment 5 2018-04-25 13:36:26 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 338764 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338764&action=review > > > Source/WTF/wtf/Compiler.h:-97 > > -#if !GCC_VERSION_AT_LEAST(5, 0, 0) > > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile." > > -#endif > > Couldn't you just increment this? It's redundant with the cmake check, but it also doesn't hurt?
Michael Catanzaro
Comment 6 2018-04-25 13:46:44 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 338764 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338764&action=review > > > Source/WTF/wtf/Compiler.h:-97 > > -#if !GCC_VERSION_AT_LEAST(5, 0, 0) > > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile." > > -#endif > > Couldn't you just increment this? Yeah, but it could easily get out of sync with the earlier build system check in the future. I think if XCode build still supports GCC (which seems doubtful?) then it can do its own checking, right?
JF Bastien
Comment 7 2018-04-25 13:47:56 PDT
(In reply to Michael Catanzaro from comment #6) > (In reply to Alex Christensen from comment #4) > > Comment on attachment 338764 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=338764&action=review > > > > > Source/WTF/wtf/Compiler.h:-97 > > > -#if !GCC_VERSION_AT_LEAST(5, 0, 0) > > > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile." > > > -#endif > > > > Couldn't you just increment this? > > Yeah, but it could easily get out of sync with the earlier build system > check in the future. I think if XCode build still supports GCC (which seems > doubtful?) then it can do its own checking, right? Isn't this a good argument to only keep the Compiler.h check instead?
Alex Christensen
Comment 8 2018-04-25 13:48:33 PDT
We don't support using gcc/Xcode to build WebKit any more.
Michael Catanzaro
Comment 9 2018-04-25 14:34:20 PDT
(In reply to JF Bastien from comment #7) > Isn't this a good argument to only keep the Compiler.h check instead? I don't think so, it's better to fail at configure time than to wait until after we've finished building bmalloc and whatever else. (In reply to Alex Christensen from comment #8) > We don't support using gcc/Xcode to build WebKit any more. Then the check in Compiler.h is guaranteed to never be hit, so let's indeed get rid of it.
EWS Watchlist
Comment 10 2018-04-25 17:25:29 PDT
Comment on attachment 338764 [details] Patch Attachment 338764 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7460735 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 11 2018-04-25 17:25:41 PDT
Created attachment 338834 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Yusuke Suzuki
Comment 12 2018-04-29 09:25:49 PDT
Ubuntu LTS 18.04 is released, it's good time to land this :)
WebKit Commit Bot
Comment 13 2018-04-29 10:30:01 PDT
Comment on attachment 338764 [details] Patch Clearing flags on attachment: 338764 Committed r231152: <https://trac.webkit.org/changeset/231152>
WebKit Commit Bot
Comment 14 2018-04-29 10:30:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-04-29 10:32:11 PDT
<rdar://problem/39825105>
Note You need to log in before you can comment on or make changes to this bug.