Bug 184631

Summary: [Extra zoom mode] Double tap to zoom should account for text legibility in extra zoom mode
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Try to fix OpenSource iOS builds
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2018-04-14 16:45:50 PDT
Part 2 of <https://bugs.webkit.org/show_bug.cgi?id=184435>.
Attachments
Patch (13.44 KB, patch)
2018-04-14 17:14 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Try to fix OpenSource iOS builds (13.48 KB, patch)
2018-04-14 19:16 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (13.18 KB, patch)
2018-04-17 19:11 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-04-14 16:46:22 PDT
<rdar://problem/39303706>
Wenson Hsieh
Comment 2 2018-04-14 17:14:30 PDT
Created attachment 337966 [details] Patch
Wenson Hsieh
Comment 3 2018-04-14 19:16:49 PDT
Created attachment 337969 [details] Try to fix OpenSource iOS builds
Tim Horton
Comment 4 2018-04-17 17:00:12 PDT
Comment on attachment 337969 [details] Try to fix OpenSource iOS builds Not sure about the logging. When is RELEASE_LOG on?
Wenson Hsieh
Comment 5 2018-04-17 17:08:23 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 337969 [details] > Try to fix OpenSource iOS builds > > Not sure about the logging. When is RELEASE_LOG on? It's on if we're building for macOS, or we're building for iOS with an internal SDK. Per IRC discussion, I'll downgrade these to debug logs.
Wenson Hsieh
Comment 6 2018-04-17 19:11:22 PDT
Created attachment 338182 [details] Patch for landing
WebKit Commit Bot
Comment 7 2018-04-17 19:50:31 PDT
Comment on attachment 338182 [details] Patch for landing Clearing flags on attachment: 338182 Committed r230746: <https://trac.webkit.org/changeset/230746>
Note You need to log in before you can comment on or make changes to this bug.