Bug 184580

Summary:

[Web Animations] Fix animations/stop-animation-on-suspend.html

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dino, graouts, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=49182

Attachments:

Description	Flags
Patch	none

Antoine Quint

Reported 2018-04-13 00:07:23 PDT

The test at animations/stop-animation-on-suspend.html fails reliably on iOS with the new animation engine.

Attachments
Patch (3.85 KB, patch) 2020-02-10 02:41 PST, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-04-13 00:07:40 PDT

<rdar://problem/39406014>

Antoine Quint

Comment 2 2018-04-13 09:08:23 PDT

This isn't specific to iOS actually, it also fails on Mac but it was already marked as a flaky Failure for that platform so the error was not reported.

Antoine Quint

Comment 3 2020-02-09 10:19:52 PST

This test has always been problematic, see https://bugs.webkit.org/show_bug.cgi?id=49182.

Antoine Quint

Comment 4 2020-02-10 02:38:36 PST

I believe the expectations of this test to be incorrect. The test animates a transform from 0 to 400px across 400ms with a linear timing function. The test suspends animations from 100ms to 300ms with timers, and polls animations at 200ms and 400ms. At 200ms, it expects a value of 100px, which is correct since the animation is suspended and so the value at 100ms (when it was suspended) is expected. However, the test expected the value at 400ms to be 200px, which leads me to think this test assumes that animations, when resumed, account for the time suspended and subtracts it from the page time. This is incorrect: when animations resume, they resume at the current time, no matter how long they were suspended. So the expected value should be 400px. I will file a patch with this change in expectation.

Antoine Quint

Comment 5 2020-02-10 02:41:33 PST

Created attachment 390238 [details] Patch

WebKit Commit Bot

Comment 6 2020-02-10 09:11:18 PST

Comment on attachment 390238 [details] Patch Clearing flags on attachment: 390238 Committed r256177: <https://trac.webkit.org/changeset/256177>

WebKit Commit Bot

Comment 7 2020-02-10 09:11:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.