Bug 182287

Summary: Rewrite fast/events/scroll-in-scaled-page-with-overflow-hidden.html to conform with CSSOM View
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: Tools / TestsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, lforschler, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 5991, 182230    
Attachments:
Description Flags
Patch tonikitoo: review+

Frédéric Wang (:fredw)
Reported 2018-01-30 05:33:40 PST
fast/events/scroll-in-scaled-page-with-overflow-hidden.html uses document.body.scrollTop to retrieve the vertical scroll offset of the viewport. This currently works because WebKit does not follow the CSSOM View spec (bug 5991). However, when CSSOMViewScrollingAPI is enabled, the HTML body is potentially scrollable (html, body have overflow: hidden see [1]) so document.body.scrollTop does not return the scroll offset [2]. Instead, the corresponding Chromium test [3] relies on internals.visualViewportScrollY(). [1] https://drafts.csswg.org/cssom-view/#potentially-scrollable [2] https://drafts.csswg.org/cssom-view/#dom-element-scrolltop [3] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html?q=scroll-in-scaled-page-with-overflow-hidden.html&sq=package:chromium&dr
Attachments
Patch (3.22 KB, patch)
2018-01-31 03:08 PST, Frédéric Wang (:fredw) 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-01-31 03:08:01 PST
Created attachment 332752 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-01-31 03:10:39 PST
(In reply to Frédéric Wang (:fredw) from comment #0) > Instead, the > corresponding Chromium test [3] relies on internals.visualViewportScrollY(). So it looks like internals.visualViewportRect().y would work too, but I've simply used window.scrollY which is what document.body.scrollTop is supposed to return when the body is not potentially scrollable: https://drafts.csswg.org/cssom-view/#dom-element-scrolltop
Frédéric Wang (:fredw)
Comment 3 2018-02-01 06:03:51 PST
Committed r227962: <https://trac.webkit.org/changeset/227962>
Radar WebKit Bug Importer
Comment 4 2018-02-01 06:05:13 PST
<rdar://problem/37113985>
Note You need to log in before you can comment on or make changes to this bug.