Bug 175474

Summary: Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170449    
Attachments:
Description Flags
Patch
none
Added an IDL test
none
Patch for landing rniwa: commit-queue+

Ryosuke Niwa
Reported 2017-08-11 00:24:36 PDT
Replace the build flag for dataTransfer.items by a runtime flag and add stub implementation to make it compile.
Attachments
Patch (102.33 KB, patch)
2017-08-11 01:10 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added an IDL test (108.60 KB, patch)
2017-08-11 10:50 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (96.68 KB, patch)
2017-08-12 14:47 PDT, Ryosuke Niwa 		rniwa: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-11 00:46:54 PDT
<rdar://problem/33844628>
Ryosuke Niwa
Comment 2 2017-08-11 01:10:50 PDT
Created attachment 317921 [details] Patch
Wenson Hsieh
Comment 3 2017-08-11 02:00:29 PDT
Comment on attachment 317921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317921&action=review LGTM with some minor comments. This might need a wk2r+ as well. Can we also write a quick LayoutTest to check that we can reference items on a DataTransfer? > ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=175474 If there's a corresponding radar, let's include it in the ChangeLogs. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-18606 > - 51F175001F358B3600C74950 /* JSServiceWorkerUpdateViaCache.cpp */, Are these changes intended? > Source/WebCore/dom/DataTransferItemList.h:49 > + { } Nit - most other classes in WebCore use a style like: { } in the constructor, even when the constructor is empty.
Ryosuke Niwa
Comment 4 2017-08-11 10:48:30 PDT
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 317921 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317921&action=review > > LGTM with some minor comments. This might need a wk2r+ as well. Can we also > write a quick LayoutTest to check that we can reference items on a > DataTransfer? I was gonna say W3C surely has a test for this but they don't :( Adding a new IDL test. > > ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=175474 > > If there's a corresponding radar, let's include it in the ChangeLogs. Added. But it doesn't really matter at this point in time since bug URL is enough to find the radar. It only starts to matter with changes that get merged into branches, or near the branching points. I guess I'm gonna stop importing to radar now that all closed bugs will create a radar automatically after the fact. > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-18606 > > - 51F175001F358B3600C74950 /* JSServiceWorkerUpdateViaCache.cpp */, > > Are these changes intended? Well, it's expected that these changes happen now that webkit-patch auto sorts xcodeproj files. > > Source/WebCore/dom/DataTransferItemList.h:49 > > + { } > > Nit - most other classes in WebCore use a style like: > > { > } > > in the constructor, even when the constructor is empty. Fixed.
Ryosuke Niwa
Comment 5 2017-08-11 10:50:16 PDT
Created attachment 317936 [details] Added an IDL test
Wenson Hsieh
Comment 6 2017-08-11 12:49:04 PDT
Comment on attachment 317936 [details] Added an IDL test View in context: https://bugs.webkit.org/attachment.cgi?id=317936&action=review > Source/WebCore/dom/DataTransferItem.cpp:46 > + Nit - Extra newline here.
Ryosuke Niwa
Comment 7 2017-08-12 14:47:09 PDT
Created attachment 318000 [details] Patch for landing
Ryosuke Niwa
Comment 8 2017-08-12 15:14:55 PDT
Committed r220627: <http://trac.webkit.org/changeset/220627>
Note You need to log in before you can comment on or make changes to this bug.