Bug 174513

Summary:

Make sure all CFHTTPCookieStorageRefs we create are scheduled

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, ggaren, jlewis3, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none

Brady Eidson

Reported 2017-07-14 11:01:51 PDT

Make sure all CFHTTPCookieStorageRefs we create are scheduled

Attachments
Patch (20.79 KB, patch) 2017-07-14 11:06 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (19.99 KB, patch) 2017-07-14 11:26 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (23.33 KB, patch) 2017-07-15 18:12 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.07 MB, application/zip) 2017-07-15 20:22 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-14 11:02:02 PDT

<rdar://problem/33221110>

Brady Eidson

Comment 2 2017-07-14 11:06:17 PDT

Created attachment 315454 [details] Patch

Tim Horton

Comment 3 2017-07-14 11:18:50 PDT

Comment on attachment 315454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315454&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391 > - buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */; > + buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */; Don't think you want this. > Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170 > - 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = { > + 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = { Or this.

Brady Eidson

Comment 4 2017-07-14 11:24:42 PDT

(In reply to Tim Horton from comment #3) > Comment on attachment 315454 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315454&action=review > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:9391 > > - buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */; > > + buildConfigurationList = 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */; > > Don't think you want this. > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:11170 > > - 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit2" */ = { > > + 1DEB91B108733DA50010E9CD /* Build configuration list for PBXProject "WebKit" */ = { > > Or this. I do, because it's The Future™, but as we discussed in person it can be in a separate patch.

Brady Eidson

Comment 5 2017-07-14 11:26:56 PDT

Created attachment 315463 [details] Patch

WebKit Commit Bot

Comment 6 2017-07-14 12:16:13 PDT

The commit-queue encountered the following flaky tests while processing attachment 315463 [details]: editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2017-07-14 12:16:44 PDT

Comment on attachment 315463 [details] Patch Clearing flags on attachment: 315463 Committed r219516: <http://trac.webkit.org/changeset/219516>

WebKit Commit Bot

Comment 8 2017-07-14 12:16:46 PDT

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 9 2017-07-14 15:39:44 PDT

This patch caused an API failure on all Macs. https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/2955/steps/run-api-tests/logs/stdio https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/2955

Matt Lewis

Comment 10 2017-07-14 15:51:41 PDT

Reverted r219516 for reason: This caused an API failure on macOS. Committed r219529: <http://trac.webkit.org/changeset/219529>

Brady Eidson

Comment 11 2017-07-15 18:12:28 PDT

Created attachment 315576 [details] Patch

Brady Eidson

Comment 12 2017-07-15 18:13:25 PDT

Letting EWS churn on this new patch and running API tests locally. The Source changes are only one line different from the last one - Tim approved this. Will CQ+ once bots and local API tests are happy

Build Bot

Comment 13 2017-07-15 20:22:18 PDT

Comment on attachment 315576 [details] Patch Attachment 315576 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4128339 New failing tests: http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html

Build Bot

Comment 14 2017-07-15 20:22:19 PDT

Created attachment 315582 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Brady Eidson

Comment 15 2017-07-15 20:28:57 PDT

(In reply to Build Bot from comment #14) > Created attachment 315582 [details] > Archive of layout-test-results from ews122 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5 These are not because of this patch.

WebKit Commit Bot

Comment 16 2017-07-15 23:57:52 PDT

Comment on attachment 315576 [details] Patch Clearing flags on attachment: 315576 Committed r219545: <http://trac.webkit.org/changeset/219545>

WebKit Commit Bot

Comment 17 2017-07-15 23:57:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.