Bug 173197

Summary: [WebCrypto] Remove experimental feature flag of SubtleCrypto
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, commit-queue, dbates, dino, esprehn+autocc, jiewen_tan, joepeck, kondapallykalyan, mcatanzaro, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch for landing none

Jiewen Tan
Reported 2017-06-09 18:03:31 PDT
Remove experimental feature flag.
Attachments
Patch (15.87 KB, patch)
2017-06-09 18:10 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (15.89 KB, patch)
2017-06-09 18:20 PDT, Jiewen Tan 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (16.03 KB, patch)
2017-06-12 12:45 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-06-09 18:04:32 PDT
<rdar://problem/32688148>
Jiewen Tan
Comment 2 2017-06-09 18:10:29 PDT
Created attachment 312523 [details] Patch
Jiewen Tan
Comment 3 2017-06-09 18:20:37 PDT
Created attachment 312524 [details] Patch
Sam Weinig
Comment 4 2017-06-09 20:36:13 PDT
This patch does not contain a reason.
Brent Fulgham
Comment 5 2017-06-12 09:45:11 PDT
Comment on attachment 312524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review > Source/WebCore/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). Please add a statement like "The SubtleCrypto implementation is no longer experimental and is ready for production use. We are therefore removing the runtime flag."
Jiewen Tan
Comment 6 2017-06-12 12:40:16 PDT
Comment on attachment 312524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review Thanks Brent for r+ my patch. >> Source/WebCore/ChangeLog:7 >> + Reviewed by NOBODY (OOPS!). > > Please add a statement like "The SubtleCrypto implementation is no longer experimental and is ready for production use. We are therefore removing the runtime flag." Fixed.
Jiewen Tan
Comment 7 2017-06-12 12:45:01 PDT
Created attachment 312686 [details] Patch for landing
WebKit Commit Bot
Comment 8 2017-06-12 13:26:29 PDT
The commit-queue encountered the following flaky tests while processing attachment 312686 [details]: imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html bug 173270 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2017-06-12 13:27:04 PDT
Comment on attachment 312686 [details] Patch for landing Clearing flags on attachment: 312686 Committed r218129: <http://trac.webkit.org/changeset/218129>
Michael Catanzaro
Comment 10 2017-06-12 18:41:47 PDT
Congrats Jiewen!
Daniel Bates
Comment 11 2017-06-13 10:14:39 PDT
Comment on attachment 312524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review > Source/WebCore/page/Crypto.idl:34 > + [Conditional=SUBTLE_CRYPTO] readonly attribute SubtleCrypto subtle; Would it be reasonable to mark this as SecureContext as per the spec.? Ideally, we would mark all WebCrypto API as SecureContext though I'm unclear if we can mark API associated with the deprecated webkitSubtle without breaking web compatibility.
Michael Catanzaro
Comment 12 2017-06-13 11:06:32 PDT
Good catch. Was webkitSubtle ever web exposed? Are we not able to just remove it?
Jiewen Tan
Comment 13 2017-06-13 13:04:14 PDT
(In reply to Daniel Bates from comment #11) > Comment on attachment 312524 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312524&action=review > > > Source/WebCore/page/Crypto.idl:34 > > + [Conditional=SUBTLE_CRYPTO] readonly attribute SubtleCrypto subtle; > > Would it be reasonable to mark this as SecureContext as per the spec.? > Ideally, we would mark all WebCrypto API as SecureContext though I'm unclear > if we can mark API associated with the deprecated webkitSubtle without > breaking web compatibility. We should mark this as SecureContext. See Bug 166959. For the webkitSubtle, I think we shouldn't.
Jiewen Tan
Comment 14 2017-06-13 13:05:23 PDT
(In reply to Michael Catanzaro from comment #12) > Good catch. > > Was webkitSubtle ever web exposed? Are we not able to just remove it? It is web exposed therefore I think we should gradually deprecate it.
Note You need to log in before you can comment on or make changes to this bug.