Bug 172602

<rdar://problem/32407693>

Created attachment 311257 [details] Patch

Attachment 311257 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311257 [details] Patch Attachment 311257 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3815718 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311264 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Created attachment 311273 [details] Patch

Attachment 311273 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311273&action=review r- with lack of test for non-standard resolution. > Source/ThirdParty/libwebrtc/ChangeLog:3 > + fix-172602 ? > Source/ThirdParty/libwebrtc/ChangeLog:20 > + * Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h: Double Changelog. > LayoutTests/ChangeLog:9 > + * webrtc/captureCanvas-webrtc.html: Using standard resolutions. we should have a test with expected behavior of non-standard resolutions as well.

> > Source/ThirdParty/libwebrtc/ChangeLog:20 > > + * Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h: > > Double Changelog. > > > LayoutTests/ChangeLog:9 > > + * webrtc/captureCanvas-webrtc.html: Using standard resolutions. > > we should have a test with expected behavior of non-standard resolutions as > well. This would require switching off the hardware encoder as some bots have one but not others. Doable with an Internals API but I am not sure this is worth it.

Created attachment 311280 [details] Patch

Attachment 311280 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311280 [details] Patch Attachment 311280 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3816614 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311290 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 311280 [details] Patch Attachment 311280 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3816548 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311293 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 311280 [details] Patch Attachment 311280 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3817068 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311306 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Created attachment 311366 [details] Patch

Attachment 311366 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:573: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 311372 [details] Patch

Attachment 311372 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:573: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 311374 [details] Patch

Attachment 311374 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:573: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 311376 [details] Patch

Attachment 311376 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:573: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311376 [details] Patch Attachment 311376 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3823914 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311384 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

(In reply to Build Bot from comment #27) > Comment on attachment 311376 [details] > Patch > > Attachment 311376 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/3823914 > > New failing tests: > webrtc/captureCanvas-webrtc.html Test is failing due to the following message appearing in the console log: AVDCreateGPUAccelerator: Error loading GPU renderer I don't think this invalidates the patch.

Comment on attachment 311376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311376&action=review > Source/WebCore/ChangeLog:12 > + Adding internal API to switch on/off hardware H264 encoder. > + Adding checks for standard size. If using a software encoder and frame size is not standard, Nit: "Adding" => "Add" > LayoutTests/webrtc/captureCanvas-webrtc.html:49 > + if (video.videoWidth === width && videoi.videoHeight === height) Nit: "videoi"

(In reply to youenn fablet from comment #29) > (In reply to Build Bot from comment #27) > > Comment on attachment 311376 [details] > > Patch > > > > Attachment 311376 [details] did not pass mac-ews (mac): > > Output: http://webkit-queues.webkit.org/results/3823914 > > > > New failing tests: > > webrtc/captureCanvas-webrtc.html > > Test is failing due to the following message appearing in the console log: > AVDCreateGPUAccelerator: Error loading GPU renderer > > I don't think this invalidates the patch. You should probably add "AVDCreateGPUAccelerator:" to the list of stderr strings that are not logged so it doesn't cause tests to be flakey on whatever configurations are causing this.

Created attachment 311549 [details] Patch for landing

(In reply to Eric Carlson from comment #31) > (In reply to youenn fablet from comment #29) > > (In reply to Build Bot from comment #27) > > > Comment on attachment 311376 [details] > > > Patch > > > > > > Attachment 311376 [details] did not pass mac-ews (mac): > > > Output: http://webkit-queues.webkit.org/results/3823914 > > > > > > New failing tests: > > > webrtc/captureCanvas-webrtc.html > > > > Test is failing due to the following message appearing in the console log: > > AVDCreateGPUAccelerator: Error loading GPU renderer > > > > I don't think this invalidates the patch. > > You should probably add "AVDCreateGPUAccelerator:" to the list of stderr > strings that are not logged so it doesn't cause tests to be flakey on > whatever configurations are causing this. Let's see whether this happens again during cq and news bots. If so, I will add it.

Attachment 311549 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:576: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311549 [details] Patch for landing Attachment 311549 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3845023 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311556 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Created attachment 311561 [details] Adding more logging for WK1

(In reply to Build Bot from comment #36) > Created attachment 311556 [details] > Archive of layout-test-results from ews103 for mac-elcapitan > > The attached test failures were seen while running run-webkit-tests on the > mac-ews. > Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6 Now this is a real failure...

Attachment 311561 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:576: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 311561 [details] Adding more logging for WK1 Attachment 311561 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3845382 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311564 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 311561 [details] Adding more logging for WK1 Attachment 311561 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3845398 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 311565 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

And here comes again "AVDCreateGPUAccelerator: Error loading GPU render"... I'll add it to the stderr filter

Created attachment 313309 [details] Patch for landing

(In reply to youenn fablet from comment #45) > Created attachment 313309 [details] > Patch for landing Adding filtering of AVDCreateGPUAccelerator.

Attachment 313309 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 313309 [details] Patch for landing Attachment 313309 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3960044 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 313319 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 313309 [details] Patch for landing Attachment 313309 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3961186 New failing tests: webrtc/captureCanvas-webrtc.html

Created attachment 313325 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Created attachment 313326 [details] Marking captureCanvas-webrtc.html as flaky on WK1

Attachment 313326 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Not running on native Windows. ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 313326 [details] Marking captureCanvas-webrtc.html as flaky on WK1 Clearing flags on attachment: 313326 Committed r218505: <http://trac.webkit.org/changeset/218505>

All reviewed patches have been landed. Closing bug.

Re-opened since this is blocked by bug 173563

Created attachment 313455 [details] Patch

Attachment 313455 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Not running on native Windows. ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm:125: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 7 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 313458 [details] Patch

Attachment 313458 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Not running on native Windows. ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 313541 [details] Patch

Attachment 313541 [details] did not pass style-queue: ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Not running on native Windows. ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:569: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:72: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 313627 [details] Patch

Attachment 313627 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm:536: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm:570: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/testing/Internals.h:583: The parameter name "allowed" adds no information, so it should be removed. [readability/parameter_name] [5] WARNING: Not running on native Windows. ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.h:73: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.h:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 313627 [details] Patch Clearing flags on attachment: 313627 Committed r218699: <http://trac.webkit.org/changeset/218699>

All reviewed patches have been landed. Closing bug.

It looks like the test platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is flaky and has been since being added. The Dashboard shows failures on all macOS testers. https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r218757%20(2498)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Fwebrtc%2FcaptureCanvas-webrtc-software-encoder.html diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/platform/mac/webrtc/captureCanvas-webrtc-software-encoder-actual.txt @@ -1,4 +1,4 @@ -PASS captureStream with webrtc +FAIL captureStream with webrtc promise_test: Unhandled rejection with value: "test4 failed"