Bug 172120

Summary: [ios-simulator] API test WKWebView.ClearAppCache is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, jlewis3
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172030
Attachments:
Description Flags
Fix that works for me locally
commit-queue: commit-queue-
Fix that works for me locally none

Ryan Haddad
Reported 2017-05-15 08:59:18 PDT
FAIL WKWebView.ClearAppCache /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:161 Value of: -1 Expected: fileSize(dbTargetURL) Which is: 57344 /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:162 Value of: -1 Expected: fileSize(walTargetURL) Which is: 0 /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:163 Value of: -1 Expected: fileSize(shmTargetURL) Which is: 32768 /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:171 Expected: (fileSize(walTargetURL)) > (0), actual: 0 vs 0 /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:179 Value of: 1ul Actual: 1 Expected: websiteDataRecords.count Which is: 0 /Volumes/Data/slave/ios-simulator-10-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:201 Value of: originalWebsiteDataRecordCount - 1 Actual: 18446744073709551615 Expected: websiteDataRecords.count Which is: 0 https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/1446
Attachments
Fix that works for me locally (2.36 KB, patch)
2017-05-15 11:43 PDT, Brady Eidson 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fix that works for me locally (2.36 KB, patch)
2017-05-15 11:54 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-05-15 10:55:26 PDT
As with the same ordeal last week when resolving https://bugs.webkit.org/show_bug.cgi?id=172030, I cannot reproduce locally with the sim.
Brady Eidson
Comment 2 2017-05-15 11:30:05 PDT
(In reply to Brady Eidson from comment #1) > As with the same ordeal last week when resolving > https://bugs.webkit.org/show_bug.cgi?id=172030, I cannot reproduce locally > with the sim. That was just the first try. It's flaky, but does reproduce over half the time. Looking...
Brady Eidson
Comment 3 2017-05-15 11:37:35 PDT
Looks like the previous code that explicitly deleted the app cache paths was necessary for the iOS-sim test. Restoring that seems to fix this.
Brady Eidson
Comment 4 2017-05-15 11:43:38 PDT
Created attachment 310151 [details] Fix that works for me locally
WebKit Commit Bot
Comment 5 2017-05-15 11:45:05 PDT
Comment on attachment 310151 [details] Fix that works for me locally Rejecting attachment 310151 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 310151, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/3745334
Brady Eidson
Comment 6 2017-05-15 11:54:28 PDT
Created attachment 310152 [details] Fix that works for me locally
WebKit Commit Bot
Comment 7 2017-05-15 12:34:32 PDT
Comment on attachment 310152 [details] Fix that works for me locally Clearing flags on attachment: 310152 Committed r216869: <http://trac.webkit.org/changeset/216869>
WebKit Commit Bot
Comment 8 2017-05-15 12:34:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.