Bug 171452

Summary: Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Addy Osmani
Reported 2017-04-28 15:02:55 PDT
As part of Speedometer 2.0 (https://bugs.webkit.org/show_bug.cgi?id=170513), add an ES2015 TodoMVC implementation that transpiles down to ES5 using Babel and Webpack. This is a variant on the implementation in https://bugs.webkit.org/show_bug.cgi?id=171448 which highlights a popular ES2015 -> ES5 transpiled code pattern very commonly seen in production today. Most developers are still doing complete ES2015 transpiles back to ES5 rather than everything their target browsers support. With this implementation we round up Speedometer's ability to track: vanilla ES5 code, vanilla ES2015 code and transpiled ES2015 code (if the other patches land).
Attachments
Patch (668.74 KB, patch)
2017-04-28 15:04 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (74.62 KB, patch)
2017-04-28 17:36 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (67.31 KB, patch)
2017-05-11 19:55 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (172.88 KB, patch)
2017-05-11 20:19 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-04-28 15:04:37 PDT
Created attachment 308599 [details] Patch
Addy Osmani
Comment 2 2017-04-28 17:36:57 PDT
Created attachment 308630 [details] Patch
Ryosuke Niwa
Comment 3 2017-05-09 14:24:15 PDT
Comment on attachment 308630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308630&action=review > PerformanceTests/ChangeLog:7 > + Adds ES2015 Babel + Webpack TodoMVC implem Again, we need a blank line before this. > PerformanceTests/ChangeLog:11 > + * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.421eb6baca02218e985e.js: Added. This file access localStorage. We probably want to avoid storing things into localStorage. r- because of this. > PerformanceTests/ChangeLog:12 > + (o): And remove these inline comments since we're just importing files.
Addy Osmani
Comment 4 2017-05-11 19:55:31 PDT
Created attachment 309854 [details] Patch
Ryosuke Niwa
Comment 5 2017-05-11 20:10:44 PDT
Comment on attachment 309854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309854&action=review > PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:23 > + localStorage[name] = JSON.stringify(data) I think we still have to get rid of these writes & reads from to localStorage.
Addy Osmani
Comment 6 2017-05-11 20:19:04 PDT
Created attachment 309857 [details] Patch
Addy Osmani
Comment 7 2017-05-11 20:21:23 PDT
This revised version uses a localStorage shim (memory.js) that will only write to memory instead of localStorage or disk. Reads and writes should only occur from memory now.
Ryosuke Niwa
Comment 8 2017-05-11 20:23:56 PDT
Comment on attachment 309857 [details] Patch Let's try CQ again now that git.webkit.org is back.
WebKit Commit Bot
Comment 9 2017-05-11 20:41:13 PDT
Comment on attachment 309857 [details] Patch Clearing flags on attachment: 309857 Committed r216727: <http://trac.webkit.org/changeset/216727>
WebKit Commit Bot
Comment 10 2017-05-11 20:41:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.