Bug 171407

Summary: RealtimeMediaSourceCenter callbacks should be passed as r-values
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixing gtk build
none
Patch for landing none

youenn fablet
Reported 2017-04-27 16:50:14 PDT
They are passed by value currently
Attachments
Patch (11.85 KB, patch)
2017-04-27 16:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing gtk build (13.00 KB, patch)
2017-04-28 10:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.64 KB, patch)
2017-05-05 23:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-04-27 16:51:16 PDT
Created attachment 308477 [details] Patch
youenn fablet
Comment 2 2017-04-28 10:24:42 PDT
Created attachment 308551 [details] Fixing gtk build
youenn fablet
Comment 3 2017-05-05 23:29:29 PDT
Created attachment 309273 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-05-06 00:22:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-05-06 00:23:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]: http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2017-05-06 01:02:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]: http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-05-06 01:02:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 309273 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2017-05-06 01:56:02 PDT
Comment on attachment 309273 [details] Patch for landing Clearing flags on attachment: 309273 Committed r216323: <http://trac.webkit.org/changeset/216323>
WebKit Commit Bot
Comment 9 2017-05-06 01:56:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.