Bug 171215

Summary:

Import W3C tests for the CSSOM View module

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

DOM

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, rego, youennf

Priority:

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

5991, 153137, 171226, 171228

Attachments:

Description	Flags
Patch	youennf: review+, buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Frédéric Wang (:fredw)

Reported 2017-04-24 03:29:57 PDT

It seems we do not have anything in imported/w3c/web-platform-tests/cssom-view for now. I think they will be useful to fix the behavior of the scrolling DOM interface (bug 5991).

Attachments
Patch (214.01 KB, patch) 2017-04-24 07:21 PDT, Frédéric Wang (:fredw)	youennf: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (20.98 MB, application/zip) 2017-04-24 08:57 PDT, Build Bot	no flags	Details
Patch (229.40 KB, patch) 2017-04-24 10:09 PDT, Frédéric Wang (:fredw)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (28.80 MB, application/zip) 2017-04-24 14:44 PDT, Build Bot	no flags	Details
Patch (229.41 KB, patch) 2017-04-24 23:16 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-04-24 07:21:45 PDT

Created attachment 307973 [details] Patch

youenn fablet

Comment 2 2017-04-24 08:09:27 PDT

Comment on attachment 307973 [details] Patch r=me Can you rerun the importer with -l option so that testharness links are not rewritten? There are discussions rewriting them' de links to relative, but for the moment I prefer keeping the style consistent.

Manuel Rego Casasnovas

Comment 3 2017-04-24 08:33:20 PDT

Comment on attachment 307973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307973&action=review I guess that for tests that have a few PASS and a few FAIL it's fine to have the "-expected" file with a mix of them. But for the tests with all FAIL, wouldn't be better to mark them as failure in TestExpectations linking to the related bugs to track them? > LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-getBoundingClientRect-002-expected.txt:2 > +FAIL getBoundingClientRect on a newly-created Element not yet inserted into the DOM should return an all-zeroes DOMRect assert_equals: DOMRect's x should be zero expected (number) 0 but got (undefined) undefined Shouldn't we mark as Failure this kind of results in TestExpectations linking the the proper bug.

Build Bot

Comment 4 2017-04-24 08:57:53 PDT

Comment on attachment 307973 [details] Patch Attachment 307973 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3594798 New failing tests: imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html

Build Bot

Comment 5 2017-04-24 08:57:55 PDT

Created attachment 307981 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Frédéric Wang (:fredw)

Comment 6 2017-04-24 10:09:21 PDT

Created attachment 307987 [details] Patch

Frédéric Wang (:fredw)

Comment 7 2017-04-24 10:10:24 PDT

(In reply to Manuel Rego Casasnovas from comment #3) > > LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-getBoundingClientRect-002-expected.txt:2 > > +FAIL getBoundingClientRect on a newly-created Element not yet inserted into the DOM should return an all-zeroes DOMRect assert_equals: DOMRect's x should be zero expected (number) 0 but got (undefined) undefined > > Shouldn't we mark as Failure this kind of results in TestExpectations > linking the the proper bug. Done. (In reply to youenn fablet from comment #2) > Comment on attachment 307973 [details] > Patch > > r=me > Can you rerun the importer with -l option so that testharness links are not > rewritten? > There are discussions rewriting them' de links to relative, but for the > moment I prefer keeping the style consistent. Done.

Build Bot

Comment 8 2017-04-24 14:44:44 PDT

Comment on attachment 307987 [details] Patch Attachment 307987 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3596627 New failing tests: imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html

Build Bot

Comment 9 2017-04-24 14:44:47 PDT

Created attachment 308012 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Frédéric Wang (:fredw)

Comment 10 2017-04-24 23:16:22 PDT

Created attachment 308072 [details] Patch

Frédéric Wang (:fredw)

Comment 11 2017-04-25 01:46:15 PDT

Committed r215726: <http://trac.webkit.org/changeset/215726>

Note You need to log in before you can comment on or make changes to this bug.