Bug 168634

Summary: [Xcode] libwebrtc installhdrs doesn’t install any of the headers
Product: WebKit Reporter: mitz
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, youennf
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167293
Attachments:
Description Flags
Patch
none
Patch none

mitz
Reported 2017-02-20 22:03:00 PST
libwebrtc’s installhdrs action doesn’t install any of its headers. It looks like the install action installs headers via a script build phase in the “Copy webrtc headers” target, but that target doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES.
Attachments
Patch (2.06 KB, patch)
2017-02-21 07:33 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.21 KB, patch)
2017-02-21 09:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-02-21 07:33:10 PST
Created attachment 302258 [details] Patch
mitz
Comment 2 2017-02-21 08:04:38 PST
Comment on attachment 302258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302258&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13 > +INSTALLHDRS_COPY_PHASE = YES; Can you explain what this is for?
mitz
Comment 3 2017-02-21 08:10:56 PST
Comment on attachment 302258 [details] Patch Can you explain how libwebrtc.xcconfig affects the “Copy webrtc headers” target? My reading of the project file is that that configuration settings file is not used for that target. Does this patch actually fix the bug?
youenn fablet
Comment 4 2017-02-21 08:14:55 PST
Let me check further.
youenn fablet
Comment 5 2017-02-21 09:24:35 PST
Created attachment 302271 [details] Patch
Alex Christensen
Comment 6 2017-02-21 15:25:40 PST
Comment on attachment 302271 [details] Patch http://trac.webkit.org/r212772
Alex Christensen
Comment 7 2017-02-21 15:26:14 PST
Comment on attachment 302271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302271&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:13 > +INSTALLHDRS_COPY_PHASE = YES; What I committed has INSTALLHDRS_SCRIPT_PHASE = YES instead of this.
Note You need to log in before you can comment on or make changes to this bug.