Bug 159392

Summary: [Xcode] With default verbosity, make(1) output no longer hides environment variable listings
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, joepeck, lforschler, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

mitz
Reported 2016-07-03 21:24:53 PDT
A long time ago, Makefile.shared was set up to filter out the environment variable listings preceding script build phase output by default by piping the output through "grep -v setenv". In version 6, Xcode switched from using “setenv” to using “export” for those listings, so the filtering stopped working. In Xcode 7, xcodebuild has a -hideShellScriptEnvironment option that suppresses the listings so they don’t need to be filtered out.
Attachments
Patch (1.11 KB, patch)
2016-07-03 21:27 PDT, mitz 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2016-07-03 21:27:17 PDT
Created attachment 282675 [details] Patch
mitz
Comment 2 2016-07-03 23:00:08 PDT
Fixed in <http://trac.webkit.org/r202798>.
Note You need to log in before you can comment on or make changes to this bug.