Bug 156041

Summary: Make BlobData use ThreadSafeSharedBuffer instead of RawData
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, clopez, commit-queue
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 143193    
Attachments:
Description Flags
Patch v1
achristensen: review+
Patch v2 - EWS and landing none

Brady Eidson
Reported 2016-03-30 14:46:00 PDT
Make BlobData thread safe This is in prep for https://bugs.webkit.org/show_bug.cgi?id=143193
Attachments
Patch v1 (37.22 KB, patch)
2016-03-30 16:59 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Patch v2 - EWS and landing (39.72 KB, patch)
2016-03-30 17:23 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-03-30 16:34:00 PDT
Retitling: Make BlobData use ThreadSafeSharedBuffer instead of RawData That's all that is really needed here. This, sadly, extends to touching various other code sites... ...but not so sad because it's a pretty nice cleanup! (removing dead code, etc)
Brady Eidson
Comment 2 2016-03-30 16:59:02 PDT
Created attachment 275238 [details] Patch v1
Brady Eidson
Comment 3 2016-03-30 17:23:38 PDT
Created attachment 275242 [details] Patch v2 - EWS and landing
WebKit Commit Bot
Comment 4 2016-03-30 18:21:03 PDT
Comment on attachment 275242 [details] Patch v2 - EWS and landing Clearing flags on attachment: 275242 Committed r198869: <http://trac.webkit.org/changeset/198869>
WebKit Commit Bot
Comment 5 2016-03-30 18:21:06 PDT
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 6 2016-03-30 20:04:11 PDT
(In reply to comment #4) > Comment on attachment 275242 [details] > Patch v2 - EWS and landing > > Clearing flags on attachment: 275242 > > Committed r198869: <http://trac.webkit.org/changeset/198869> This broke the GTK+ debug build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/57122/steps/compile-webkit/logs/stdio/text
Brady Eidson
Comment 7 2016-03-30 20:59:52 PDT
(In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 275242 [details] > > Patch v2 - EWS and landing > > > > Clearing flags on attachment: 275242 > > > > Committed r198869: <http://trac.webkit.org/changeset/198869> > > This broke the GTK+ debug build: > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/ > builds/57122/steps/compile-webkit/logs/stdio/text I fixed The build breakage from GTK EWS, which gave the final patch the green light. That's about all that was in my power to do...
Brady Eidson
Comment 8 2016-03-30 21:19:35 PDT
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > Comment on attachment 275242 [details] > > > Patch v2 - EWS and landing > > > > > > Clearing flags on attachment: 275242 > > > > > > Committed r198869: <http://trac.webkit.org/changeset/198869> > > > > This broke the GTK+ debug build: > > > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/ > > builds/57122/steps/compile-webkit/logs/stdio/text > > I fixed The build breakage from GTK EWS, which gave the final patch the > green light. > > That's about all that was in my power to do... Easy fixes... ASSERT(blobItem.type == BlobDataItem::Type::File); becomes ASSERT(blobItem.type() == BlobDataItem::Type::File); I'm at home without a clean checkout. If nobody has fixed that by tomorrow morning I'll check it in when I get into the office.
Alex Christensen
Comment 9 2016-03-30 22:45:14 PDT
http://trac.webkit.org/changeset/198883
Note You need to log in before you can comment on or make changes to this bug.