Bug 154922

Summary: Modern IDB: Close UniqueIDBDatabases once they become unused
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
none
Patch v1 with more style
none
Patch for landing none

Brady Eidson
Reported 2016-03-02 10:54:49 PST
Modern IDB: Close UniqueIDBDatabases once they become unused Besides just being a good idea, this was actually causing problems in testing on OS X as once a DatabaseProcess (or DumpRenderTree) accumulated ~256 open UniqueIDBDatabases it run up against the launchd enforced "256 open file handles" limit.
Attachments
Patch v1 (25.41 KB, patch)
2016-03-02 12:21 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 with more style (25.44 KB, patch)
2016-03-02 12:26 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.58 KB, patch)
2016-03-02 14:53 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-03-02 12:21:01 PST
Created attachment 272674 [details] Patch v1
WebKit Commit Bot
Comment 2 2016-03-02 12:22:55 PST
Attachment 272674 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:601: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2016-03-02 12:26:04 PST
Created attachment 272675 [details] Patch v1 with more style
Alex Christensen
Comment 4 2016-03-02 14:14:53 PST
Comment on attachment 272675 [details] Patch v1 with more style View in context: https://bugs.webkit.org/attachment.cgi?id=272675&action=review Please add a test that opens too many databases and hits the expected error. > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1137 > + // Assuming it is not ephemeral, the server should now close it to free up resources. Why do we only close non-ephemeral databases? Shouldn't a memory backing store just not do anything when it closes? I think this is unnecessary complexity.
Brady Eidson
Comment 5 2016-03-02 14:24:09 PST
(In reply to comment #4) > Comment on attachment 272675 [details] > Patch v1 with more style > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272675&action=review > > Please add a test that opens too many databases and hits the expected error. > > > Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1137 > > + // Assuming it is not ephemeral, the server should now close it to free up resources. > > Why do we only close non-ephemeral databases? Shouldn't a memory backing > store just not do anything when it closes? I think this is unnecessary > complexity. As discussed in person, opening, then closing, then reopening a database in private browsing needs to work - you need to get back to the same in-memory data. The only reason we can close *persistent* databases is because we can get them back from disk.
Brady Eidson
Comment 6 2016-03-02 14:53:21 PST
Created attachment 272689 [details] Patch for landing
Brady Eidson
Comment 7 2016-03-02 14:53:44 PST
(Alex said r+ in person, didn't twiddle the review bit here in the bug)
Brady Eidson
Comment 8 2016-03-02 15:27:53 PST
https://bugs.webkit.org/show_bug.cgi?id=154706 was caused by this bug.
WebKit Commit Bot
Comment 9 2016-03-02 16:23:40 PST
Comment on attachment 272689 [details] Patch for landing Clearing flags on attachment: 272689 Committed r197474: <http://trac.webkit.org/changeset/197474>
Note You need to log in before you can comment on or make changes to this bug.