Bug 154531

Summary: Refactor DOM Iterator next signature
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore JavaScriptAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2016-02-22 02:28:32 PST
As suggested in bug 154413, Iterator::next could be simplified to Optional<...> next() instead of bool next(...)
Attachments
Patch (6.80 KB, patch)
2016-02-22 02:36 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.41 KB, patch)
2016-02-23 00:38 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-02-22 02:36:27 PST
Created attachment 271913 [details] Patch
Myles C. Maxfield
Comment 2 2016-02-22 09:26:32 PST
Comment on attachment 271913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271913&action=review > Source/WebCore/bindings/js/JSKeyValueIterator.h:152 > + auto iteratorValue = m_iterator.next(); Maybe it is worth taking the same approach in the return of this function.
youenn fablet
Comment 3 2016-02-22 09:56:47 PST
(In reply to comment #2) > Comment on attachment 271913 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271913&action=review > > > Source/WebCore/bindings/js/JSKeyValueIterator.h:152 > > + auto iteratorValue = m_iterator.next(); > > Maybe it is worth taking the same approach in the return of this function. Let's JSKeyValueIterator<JSWrapper>::next return the iterator object directly. This way, no need for boolean/JSValue or Optional for that method.
youenn fablet
Comment 4 2016-02-23 00:38:34 PST
Created attachment 271993 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-02-23 01:39:28 PST
Comment on attachment 271993 [details] Patch for landing Clearing flags on attachment: 271993 Committed r196973: <http://trac.webkit.org/changeset/196973>
WebKit Commit Bot
Comment 6 2016-02-23 01:39:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.