Bug 154388

Summary: Remove vcxproj build system
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, fpizlo, fred.wang, ossy
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
patch
none
patch
none
patch
none
patch
none
patch none

Csaba Osztrogonác
Reported 2016-02-18 02:19:22 PST
https://lists.webkit.org/pipermail/webkit-dev/2015-September/027679.html Windows ports (Apple and WinCairo) switched to cmake 4 months ago, vcxproj files are dead code, we should remove them from the trunk. There are random/speculative changes for these files since then for nothing.
Attachments
Patch (608.45 KB, patch)
2016-02-23 08:17 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.54 MB, patch)
2016-02-23 08:23 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.54 MB, patch)
2016-02-23 08:46 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (3.54 MB, patch)
2016-02-23 08:57 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (3.54 MB, patch)
2016-02-23 09:11 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (3.54 MB, patch)
2016-02-23 09:31 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (11.17 KB, patch)
2016-02-23 09:51 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (3.53 MB, patch)
2016-02-23 09:55 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-02-23 08:17:59 PST
Created attachment 272018 [details] Patch WIP patch, let's start with the JavaScriptCore directory.
Csaba Osztrogonác
Comment 2 2016-02-23 08:23:56 PST
Created attachment 272019 [details] Patch WIP patch, JSC and WebCore directories.
Csaba Osztrogonác
Comment 3 2016-02-23 08:43:24 PST
(In reply to comment #2) > Created attachment 272019 [details] > Patch > > WIP patch, JSC and WebCore directories. The patch applies to trunk fine, but svn-apply reports false positive error when removing 0 byte sized files.
Csaba Osztrogonác
Comment 4 2016-02-23 08:46:32 PST
Created attachment 272020 [details] Patch WIP. With svn-apply hack to let EWS test to build with this patch.
Csaba Osztrogonác
Comment 5 2016-02-23 08:57:19 PST
Created attachment 272021 [details] patch
Csaba Osztrogonác
Comment 6 2016-02-23 09:11:46 PST
Created attachment 272022 [details] patch temporarily don't remove emtpy files to make EWS happy
Alex Christensen
Comment 7 2016-02-23 09:16:38 PST
We have intentionally left these files in the tree. We have not done all the internal validation we need to with the new build system. We will remove them when we do.
Csaba Osztrogonác
Comment 8 2016-02-23 09:24:03 PST
(In reply to comment #7) > We have intentionally left these files in the tree. We have not done all > the internal validation we need to with the new build system. We will > remove them when we do. The question is if the old build system is still used and working fine or not. If the answer is no, it is dead code and should be removed from the trunk as soon as possible. Just ask Filip about this very important rule. ;)
Csaba Osztrogonác
Comment 9 2016-02-23 09:31:11 PST
Created attachment 272024 [details] patch
Csaba Osztrogonác
Comment 10 2016-02-23 09:51:32 PST
Created attachment 272025 [details] patch
Csaba Osztrogonác
Comment 11 2016-02-23 09:55:54 PST
Created attachment 272027 [details] patch
Alex Christensen
Comment 12 2016-03-04 11:37:32 PST
I'm going to proceed with this. There are still a few things that happen to be in the vcxproj directories that we still need, such as DLLLauncherMain.cpp, so this won't be done all in one patch.
Alex Christensen
Comment 13 2016-03-04 11:49:09 PST
http://trac.webkit.org/changeset/197578
Alex Christensen
Comment 14 2016-03-04 12:00:01 PST
http://trac.webkit.org/changeset/197579
Alex Christensen
Comment 15 2016-03-04 13:36:14 PST
http://trac.webkit.org/changeset/197586
Note You need to log in before you can comment on or make changes to this bug.