Bug 152829

Summary: Use a pointer instead of PassRefPtr in AbstractView argument of UIEvent class
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, darin, esprehn+autocc, kangil.han, rniwa
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews117 for mac-yosemite
none
Patch none

Gyuyoung Kim
Reported 2016-01-07 01:11:16 PST
As a step to reduce uses of PassRefPtr, UIEvent class doesn't need to use PassRefPtr for AbstractView argument. Nobody hands us ownership when making one of these objects.
Attachments
Patch (30.17 KB, patch)
2016-01-07 01:14 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (32.90 KB, patch)
2016-01-07 18:08 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.05 MB, application/zip)
2016-01-07 18:40 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews101 for mac-yosemite (951.21 KB, application/zip)
2016-01-07 18:58 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-yosemite (874.31 KB, application/zip)
2016-01-07 19:01 PST, Build Bot 		no flags
Details
Patch (32.65 KB, patch)
2016-01-08 20:19 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2016-01-07 01:14:42 PST
Created attachment 268446 [details] Patch
Gyuyoung Kim
Comment 2 2016-01-07 18:08:14 PST
Created attachment 268520 [details] Patch
WebKit Commit Bot
Comment 3 2016-01-07 18:09:25 PST
Attachment 268520 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MouseEvent.cpp:131: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 4 2016-01-07 18:40:25 PST
Comment on attachment 268520 [details] Patch Attachment 268520 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/664814 New failing tests: jquery/event.html
Build Bot
Comment 5 2016-01-07 18:40:29 PST
Created attachment 268522 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Chris Dumez
Comment 6 2016-01-07 18:54:12 PST
Comment on attachment 268520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268520&action=review > Source/WebCore/dom/UIEvent.h:85 > + AbstractView* m_view; You are no longer refing the view here, why is this ok?
Build Bot
Comment 7 2016-01-07 18:58:15 PST
Comment on attachment 268520 [details] Patch Attachment 268520 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/664880 New failing tests: jquery/event.html
Build Bot
Comment 8 2016-01-07 18:58:18 PST
Created attachment 268523 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-01-07 19:01:39 PST
Comment on attachment 268520 [details] Patch Attachment 268520 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/664869 New failing tests: jquery/event.html
Build Bot
Comment 10 2016-01-07 19:01:44 PST
Created attachment 268525 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Gyuyoung Kim
Comment 11 2016-01-08 20:19:49 PST
Created attachment 268606 [details] Patch
WebKit Commit Bot
Comment 12 2016-01-08 20:21:10 PST
Attachment 268606 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MouseEvent.cpp:131: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 13 2016-01-08 21:27:24 PST
(In reply to comment #6) > Comment on attachment 268520 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268520&action=review > > > Source/WebCore/dom/UIEvent.h:85 > > + AbstractView* m_view; > > You are no longer refing the view here, why is this ok? I did same fault. Fixed it.
WebKit Commit Bot
Comment 14 2016-01-12 09:24:06 PST
Comment on attachment 268606 [details] Patch Clearing flags on attachment: 268606 Committed r194896: <http://trac.webkit.org/changeset/194896>
WebKit Commit Bot
Comment 15 2016-01-12 09:24:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.