Bug 152537

Summary: [ES6] Arrow function. Default arguments in arrow functions
Product: WebKit Reporter: GSkachkov <gskachkov>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gskachkov, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140855    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

GSkachkov
Reported 2015-12-23 13:33:38 PST
arrow function should support default parameters in argument declaration var arrow = (param1, param2 = "default-value") => { console.log(param2); }
Attachments
Patch (4.04 KB, patch)
2016-01-21 11:53 PST, GSkachkov 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2016-01-21 12:09 PST, GSkachkov 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2016-01-22 02:26 PST, GSkachkov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
GSkachkov
Comment 1 2016-01-21 11:53:59 PST
Created attachment 269476 [details] Patch Fix comments
GSkachkov
Comment 2 2016-01-21 12:09:41 PST
Created attachment 269480 [details] Patch Add tests
Saam Barati
Comment 3 2016-01-21 15:45:54 PST
Comment on attachment 269480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269480&action=review > LayoutTests/js/script-tests/arrowfunction-syntax.js:90 > +shouldBe("((x, y = 'default-value') => x + y)('input-value:')",'"input-value:default-value"'); you should add a test where you pass in: - "undefined" for y - anything that isn't undefined for y
GSkachkov
Comment 4 2016-01-22 02:26:44 PST
Created attachment 269564 [details] Patch Fix comments
WebKit Commit Bot
Comment 5 2016-01-22 10:47:49 PST
Comment on attachment 269564 [details] Patch Clearing flags on attachment: 269564 Committed r195461: <http://trac.webkit.org/changeset/195461>
WebKit Commit Bot
Comment 6 2016-01-22 10:47:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.