Bug 151731

Summary: Modern IDB: storage/indexeddb/cursor-advance.html fails
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, cdumez, cgarcia, commit-queue, esprehn+autocc, jsbell, kondapallykalyan
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 151807    
Bug Blocks: 149117, 150882    
Attachments:
Description Flags
Patch v1
none
Patch v2
beidson: review-, beidson: commit-queue-
Patch v3
achristensen: review+, achristensen: commit-queue-
Patch for landing none

Brady Eidson
Reported 2015-12-01 16:45:46 PST
Modern IDB: storage/indexeddb/cursor-advance.html fails It expects detailed error messages on the exceptions that are thrown. One of them we can match exactly. The others we'll give a good message for and then update the test results.
Attachments
Patch v1 (13.32 KB, patch)
2015-12-01 16:54 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 (13.32 KB, patch)
2015-12-01 17:00 PST, Brady Eidson 		beidson: review-
beidson: commit-queue-
DetailsFormatted DiffDiff
Patch v3 (15.36 KB, patch)
2015-12-03 11:12 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (15.92 KB, patch)
2015-12-03 11:35 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-12-01 16:54:45 PST
Created attachment 266411 [details] Patch v1
WebKit Commit Bot
Comment 2 2015-12-01 16:55:30 PST
Attachment 266411 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMBinding.cpp:245: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2015-12-01 17:00:22 PST
Created attachment 266412 [details] Patch v2
Brady Eidson
Comment 4 2015-12-03 11:12:30 PST
Created attachment 266537 [details] Patch v3
Alex Christensen
Comment 5 2015-12-03 11:24:23 PST
Comment on attachment 266537 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=266537&action=review r=me with one comment. > Source/WebCore/bindings/js/JSDOMBinding.cpp:226 > +static JSValue createDOMException(ExecState* exec, ExceptionCode ec, const String& message) Less duplicate code. Share with the original createDOMException.
Brady Eidson
Comment 6 2015-12-03 11:35:41 PST
Created attachment 266539 [details] Patch for landing
WebKit Commit Bot
Comment 7 2015-12-03 12:07:16 PST
Comment on attachment 266539 [details] Patch for landing Clearing flags on attachment: 266539 Committed r193364: <http://trac.webkit.org/changeset/193364>
WebKit Commit Bot
Comment 8 2015-12-03 12:07:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.