Bug 150765

Summary: Update to match text-orientation spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kojii
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 150766    
Bug Blocks: 150822    
Attachments:
Description Flags
Patch none

Myles C. Maxfield
Reported 2015-10-31 20:35:44 PDT
We currently have implemented an old version of the CSS Writing Modes [1] spec. We should update it. AFAICT, this is the state of things: 1. Our "vertical-right" value matches the spec's "mixed" value 2. Our "upright" value matches the spec 3. Our "sideways-right" value matches the spec 4. We need to implement "sideways-left" 5. We need to update "sideways" to correctly match sideways-right / sideways-left [1] http://www.w3.org/TR/css-writing-modes-3
Attachments
Patch (6.27 KB, patch)
2015-11-02 21:09 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Koji Ishii
Comment 1 2015-11-02 02:18:25 PST
A few comments: * text-orientation: sideways-left is gone, no worry for that. writing-mode: sideways-lr, sideways-rl were added instead, so that we don't have to flip baseline within a single BFC. They're at risk though. * text-combine was updated in both property name and value name, great if you could take care of this change too.
Myles C. Maxfield
Comment 2 2015-11-02 16:07:06 PST
(In reply to comment #1) > A few comments: > * text-orientation: sideways-left is gone, no worry for that. writing-mode: > sideways-lr, sideways-rl were added instead, so that we don't have to flip > baseline within a single BFC. They're at risk though. > * text-combine was updated in both property name and value name, great if > you could take care of this change too. Thanks, Koji! I wasn't reading the dev version of the spec. I should make "sideways" a simple alias to "sideways-right". Updating "writing-mode" to match the spec is a different bug. https://bugs.webkit.org/show_bug.cgi?id=150820 Same thing for text-combine: https://bugs.webkit.org/show_bug.cgi?id=150821
Myles C. Maxfield
Comment 3 2015-11-02 21:09:01 PST
Created attachment 264661 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-03 09:14:17 PST
Comment on attachment 264661 [details] Patch Clearing flags on attachment: 264661 Committed r191953: <http://trac.webkit.org/changeset/191953>
WebKit Commit Bot
Comment 5 2015-11-03 09:14:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.