Bug 150673

Summary: Modern IDB: deleteObjectStore support
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=150804
Bug Depends on: 150719    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1 achristensen: review+

Brady Eidson
Reported 2015-10-29 09:22:16 PDT
Modern IDB: deleteObjectStore support
Attachments
Patch v1 (70.24 KB, patch)
2015-10-29 13:53 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-10-29 13:53:32 PDT
Created attachment 264341 [details] Patch v1
Alex Christensen
Comment 2 2015-10-29 14:35:51 PDT
Comment on attachment 264341 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=264341&action=review > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:456 > + auto objectStore = m_referencedObjectStores.take(objectStoreName); > + if (objectStore) Declaration could be inside if > Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:88 > + auto addResult = m_deletedObjectStores.add(objectStore->info().name(), nullptr); ASSERT(objectStore) > Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:262 > + space
Brady Eidson
Comment 3 2015-10-29 15:11:38 PDT
https://trac.webkit.org/changeset/191758
Note You need to log in before you can comment on or make changes to this bug.