Bug 148246

Summary: jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: basile_clement
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2015-08-20 14:19:46 PDT
Because we need to use a callee save register to make C++ calls to check the stack, we save the callee save register before moving the stack pointer to its eventual location. This is dangerous because a signal could temporarily take over the stack and overwrite the callee saves. We need to move the stack pointer at least enough to "protect" the callee saves.
Attachments
Patch (1.59 KB, patch)
2015-08-20 14:25 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-08-20 14:25:49 PDT
Created attachment 259495 [details] Patch
Michael Saboff
Comment 2 2015-08-20 14:55:17 PDT
Committed r188706: <http://trac.webkit.org/changeset/188706>
Basile Clement
Comment 3 2015-08-31 18:10:10 PDT
*** This bug has been marked as a duplicate of bug 148666 ***
Csaba Osztrogonác
Comment 4 2015-09-14 11:00:08 PDT
Comment on attachment 259495 [details] Patch Cleared review? from attachment 259495 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.