Bug 145750

Summary: Purge PassRefPtr in JavaScriptCore
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Gyuyoung Kim
Reported 2015-06-07 21:14:57 PDT
SSIA
Attachments
Patch (53.95 KB, patch)
2015-06-07 21:20 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (48.60 KB, patch)
2015-06-08 00:54 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (50.70 KB, patch)
2015-06-08 09:04 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (50.69 KB, patch)
2015-06-08 17:08 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.52 KB, patch)
2015-06-08 18:16 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.51 KB, patch)
2015-06-08 19:16 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-06-07 21:20:58 PDT
Created attachment 254470 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-08 00:54:39 PDT
Created attachment 254478 [details] Patch
Gyuyoung Kim
Comment 3 2015-06-08 09:04:39 PDT
Created attachment 254495 [details] Patch
Gyuyoung Kim
Comment 4 2015-06-08 17:08:59 PDT
Created attachment 254525 [details] Patch
Darin Adler
Comment 5 2015-06-08 17:22:20 PDT
Comment on attachment 254525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254525&action=review > Source/JavaScriptCore/heap/EdenGCActivityCallback.h:32 > +#include <wtf/RefPtr.h> > + This change is not needed.
Gyuyoung Kim
Comment 6 2015-06-08 18:16:19 PDT
Created attachment 254532 [details] Patch for landing
WebKit Commit Bot
Comment 7 2015-06-08 19:02:12 PDT
Comment on attachment 254532 [details] Patch for landing Rejecting attachment 254532 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254532, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6213330268061696
Gyuyoung Kim
Comment 8 2015-06-08 19:16:27 PDT
Created attachment 254538 [details] Patch for landing
Gyuyoung Kim
Comment 9 2015-06-08 19:18:22 PDT
Comment on attachment 254538 [details] Patch for landing Clearing flags on attachment: 254538 Committed r185346: <http://trac.webkit.org/changeset/185346>
Gyuyoung Kim
Comment 10 2015-06-08 19:18:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.